Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-21 Thread David Miller
From: Xin Long Date: Fri, 19 May 2017 22:20:29 +0800 > Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop > kernel hello and hold timers"), bridge would not start hello_timer if > stp_enabled is not KERNEL_STP when br_dev_open. > > The problem is even if users set stp_enabled

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 Thread Ivan Vecera
2017-05-19 16:20 GMT+02:00 Xin Long : > Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop > kernel hello and hold timers"), bridge would not start hello_timer if > stp_enabled is not KERNEL_STP when br_dev_open. > > The problem is even if users set stp_enabled with KERNEL_STP l

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 Thread Nikolay Aleksandrov
On 5/19/17 5:20 PM, Xin Long wrote: Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop kernel hello and hold timers"), bridge would not start hello_timer if stp_enabled is not KERNEL_STP when br_dev_open. The problem is even if users set stp_enabled with KERNEL_STP later, the

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 Thread Ivan Vecera
2017-05-19 17:05 GMT+02:00 Nikolay Aleksandrov : > On 5/19/17 6:03 PM, Ivan Vecera wrote: >> >> 2017-05-19 16:57 GMT+02:00 Nikolay Aleksandrov >> : >>> >>> On 5/19/17 5:51 PM, Ivan Vecera wrote: 2017-05-19 16:45 GMT+02:00 Nikolay Aleksandrov : > > > On 5/19/17 5:20 P

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 Thread Nikolay Aleksandrov
On 5/19/17 6:03 PM, Ivan Vecera wrote: 2017-05-19 16:57 GMT+02:00 Nikolay Aleksandrov : On 5/19/17 5:51 PM, Ivan Vecera wrote: 2017-05-19 16:45 GMT+02:00 Nikolay Aleksandrov : On 5/19/17 5:20 PM, Xin Long wrote: Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop kernel

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 Thread Ivan Vecera
2017-05-19 16:57 GMT+02:00 Nikolay Aleksandrov : > On 5/19/17 5:51 PM, Ivan Vecera wrote: >> >> 2017-05-19 16:45 GMT+02:00 Nikolay Aleksandrov >> : >>> >>> On 5/19/17 5:20 PM, Xin Long wrote: Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop kernel hello and

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 Thread Nikolay Aleksandrov
On 5/19/17 5:48 PM, Florian Westphal wrote: Nikolay Aleksandrov wrote: On 5/19/17 5:20 PM, Xin Long wrote: Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop kernel hello and hold timers"), bridge would not start hello_timer if stp_enabled is not KERNEL_STP when br_dev_open

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 Thread Nikolay Aleksandrov
On 5/19/17 5:51 PM, Ivan Vecera wrote: 2017-05-19 16:45 GMT+02:00 Nikolay Aleksandrov : On 5/19/17 5:20 PM, Xin Long wrote: Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop kernel hello and hold timers"), bridge would not start hello_timer if stp_enabled is not KERNEL_STP

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 Thread Ivan Vecera
2017-05-19 16:45 GMT+02:00 Nikolay Aleksandrov : > On 5/19/17 5:20 PM, Xin Long wrote: >> >> Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop >> kernel hello and hold timers"), bridge would not start hello_timer if >> stp_enabled is not KERNEL_STP when br_dev_open. >> >> The p

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 Thread Florian Westphal
Nikolay Aleksandrov wrote: > On 5/19/17 5:20 PM, Xin Long wrote: > >Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop > >kernel hello and hold timers"), bridge would not start hello_timer if > >stp_enabled is not KERNEL_STP when br_dev_open. > > > >The problem is even if users

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 Thread Nikolay Aleksandrov
On 5/19/17 5:20 PM, Xin Long wrote: Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop kernel hello and hold timers"), bridge would not start hello_timer if stp_enabled is not KERNEL_STP when br_dev_open. The problem is even if users set stp_enabled with KERNEL_STP later, the

[PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 Thread Xin Long
Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop kernel hello and hold timers"), bridge would not start hello_timer if stp_enabled is not KERNEL_STP when br_dev_open. The problem is even if users set stp_enabled with KERNEL_STP later, the timer will still not be started. It c