Re: [PATCH net] bridge: netlink: register netdevice before executing changelink

On Fri, 7 Apr 2017 21:16:49 +0300 Ido Schimmel wrote: > On Fri, Apr 07, 2017 at 01:37:53PM -0400, Stephen Hemminger wrote: > > Fix it right now. The patch you propose is too half baked. > > Given this patch needs to be back ported to three different stable > kernels I tried to keep the amount

Re: [PATCH net] bridge: netlink: register netdevice before executing changelink

On Fri, 7 Apr 2017 21:16:49 +0300 Ido Schimmel wrote: > On Fri, Apr 07, 2017 at 01:37:53PM -0400, Stephen Hemminger wrote: > > Fix it right now. The patch you propose is too half baked. > > Given this patch needs to be back ported to three different stable > kernels I tried to keep the amount

Re: [PATCH net] bridge: netlink: register netdevice before executing changelink

On Fri, Apr 07, 2017 at 01:37:53PM -0400, Stephen Hemminger wrote: > Fix it right now. The patch you propose is too half baked. Given this patch needs to be back ported to three different stable kernels I tried to keep the amount of changes to a minimum while fixing the bug. I'll work on the ndo_

Re: [PATCH net] bridge: netlink: register netdevice before executing changelink

On Fri, 7 Apr 2017 18:43:06 +0300 Nikolay Aleksandrov wrote: > On 07/04/17 18:36, Stephen Hemminger wrote: > > On Fri, 7 Apr 2017 18:27:37 +0300 > > Nikolay Aleksandrov wrote: > > > >> On 07/04/17 18:22, Stephen Hemminger wrote: > >>> On Fri, 7 Apr 2017 17:19:48 +0300 > >>> Nikolay Aleksand

Re: [PATCH net] bridge: netlink: register netdevice before executing changelink

On 07/04/17 18:36, Stephen Hemminger wrote: > On Fri, 7 Apr 2017 18:27:37 +0300 > Nikolay Aleksandrov wrote: > >> On 07/04/17 18:22, Stephen Hemminger wrote: >>> On Fri, 7 Apr 2017 17:19:48 +0300 >>> Nikolay Aleksandrov wrote: >>> On 07/04/17 17:10, Stephen Hemminger wrote: > On Fr

Re: [PATCH net] bridge: netlink: register netdevice before executing changelink

On Fri, 7 Apr 2017 18:27:37 +0300 Nikolay Aleksandrov wrote: > On 07/04/17 18:22, Stephen Hemminger wrote: > > On Fri, 7 Apr 2017 17:19:48 +0300 > > Nikolay Aleksandrov wrote: > > > >> On 07/04/17 17:10, Stephen Hemminger wrote: > >>> On Fri, 7 Apr 2017 15:49:15 +0300 > >>> wrote: > >>>

Re: [PATCH net] bridge: netlink: register netdevice before executing changelink

On 07/04/17 18:22, Stephen Hemminger wrote: > On Fri, 7 Apr 2017 17:19:48 +0300 > Nikolay Aleksandrov wrote: > >> On 07/04/17 17:10, Stephen Hemminger wrote: >>> On Fri, 7 Apr 2017 15:49:15 +0300 >>> wrote: >>> From: Ido Schimmel Peter reported a kernel oops when executing the

Re: [PATCH net] bridge: netlink: register netdevice before executing changelink

On Fri, 7 Apr 2017 17:19:48 +0300 Nikolay Aleksandrov wrote: > On 07/04/17 17:10, Stephen Hemminger wrote: > > On Fri, 7 Apr 2017 15:49:15 +0300 > > wrote: > > > >> From: Ido Schimmel > >> > >> Peter reported a kernel oops when executing the following command: > >> > >> $ ip link add name te

Re: [PATCH net] bridge: netlink: register netdevice before executing changelink

On 07/04/17 17:10, Stephen Hemminger wrote: > On Fri, 7 Apr 2017 15:49:15 +0300 > wrote: > >> From: Ido Schimmel >> >> Peter reported a kernel oops when executing the following command: >> >> $ ip link add name test type bridge vlan_default_pvid 1 >> >> [13634.939408] BUG: unable to handle kerne

Re: [PATCH net] bridge: netlink: register netdevice before executing changelink

On Fri, 7 Apr 2017 15:49:15 +0300 wrote: > From: Ido Schimmel > > Peter reported a kernel oops when executing the following command: > > $ ip link add name test type bridge vlan_default_pvid 1 > > [13634.939408] BUG: unable to handle kernel NULL pointer dereference at > 0190 > [13

[PATCH net] bridge: netlink: register netdevice before executing changelink

From: Ido Schimmel Peter reported a kernel oops when executing the following command: $ ip link add name test type bridge vlan_default_pvid 1 [13634.939408] BUG: unable to handle kernel NULL pointer dereference at 0190 [13634.939436] IP: __vlan_add+0x73/0x5f0 [...] [13634.939783] Ca