Re: [PATCH net] bpf: fix bpf_skb_in_cgroup helper naming

2016-08-12 Thread Martin KaFai Lau
On Fri, Aug 12, 2016 at 10:17:17PM +0200, Daniel Borkmann wrote: > While hashing out BPF's current_task_under_cgroup helper bits, it came > to discussion that the skb_in_cgroup helper name was suboptimally chosen. > > Tejun says: > > So, I think in_cgroup should mean that the object is in that >

Re: [PATCH net] bpf: fix bpf_skb_in_cgroup helper naming

2016-08-12 Thread David Miller
From: Daniel Borkmann Date: Fri, 12 Aug 2016 22:17:17 +0200 > While hashing out BPF's current_task_under_cgroup helper bits, it came > to discussion that the skb_in_cgroup helper name was suboptimally chosen. > > Tejun says: > > So, I think in_cgroup should mean that the object is in that >

Re: [PATCH net] bpf: fix bpf_skb_in_cgroup helper naming

2016-08-12 Thread Alexei Starovoitov
On Fri, Aug 12, 2016 at 10:17:17PM +0200, Daniel Borkmann wrote: > While hashing out BPF's current_task_under_cgroup helper bits, it came > to discussion that the skb_in_cgroup helper name was suboptimally chosen. > > Tejun says: > > So, I think in_cgroup should mean that the object is in that

[PATCH net] bpf: fix bpf_skb_in_cgroup helper naming

2016-08-12 Thread Daniel Borkmann
While hashing out BPF's current_task_under_cgroup helper bits, it came to discussion that the skb_in_cgroup helper name was suboptimally chosen. Tejun says: So, I think in_cgroup should mean that the object is in that particular cgroup while under_cgroup in the subhierarchy of that cgroup.