Re: [PATCH net] bpf: don't indicate success when copy_from_user fails

2017-07-29 Thread David Miller
From: Daniel Borkmann Date: Thu, 27 Jul 2017 21:02:46 +0200 > err in bpf_prog_get_info_by_fd() still holds 0 at that time from prior > check_uarg_tail_zero() check. Explicitly return -EFAULT instead, so > user space can be notified of buggy behavior. > > Fixes: 1e2709769086 ("bpf: Add BPF_OBJ_GE

Re: [PATCH net] bpf: don't indicate success when copy_from_user fails

2017-07-29 Thread Martin KaFai Lau
On Fri, Jul 28, 2017 at 3:02 AM, Daniel Borkmann wrote: > err in bpf_prog_get_info_by_fd() still holds 0 at that time from prior > check_uarg_tail_zero() check. Explicitly return -EFAULT instead, so > user space can be notified of buggy behavior. Thanks for fixing it. (I am on PTO and cannot use m

[PATCH net] bpf: don't indicate success when copy_from_user fails

2017-07-27 Thread Daniel Borkmann
err in bpf_prog_get_info_by_fd() still holds 0 at that time from prior check_uarg_tail_zero() check. Explicitly return -EFAULT instead, so user space can be notified of buggy behavior. Fixes: 1e2709769086 ("bpf: Add BPF_OBJ_GET_INFO_BY_FD") Signed-off-by: Daniel Borkmann --- kernel/bpf/syscall.c