Re: [PATCH net] be2net: Synchronize be_update_queues with dev_watchdog

2019-07-21 Thread David Miller
From: Benjamin Poirier Date: Thu, 18 Jul 2019 10:42:18 +0900 > As pointed out by Firo Yang, a netdev tx timeout may trigger just before an > ethtool set_channels operation is started. be_tx_timeout(), which dumps > some queue structures, is not written to run concurrently with > be_update_queues(

Re: [PATCH net] be2net: Synchronize be_update_queues with dev_watchdog

2019-07-18 Thread Benjamin Poirier
On 2019/07/18 10:23, Florian Fainelli wrote: > On 7/17/19 6:42 PM, Benjamin Poirier wrote: > > As pointed out by Firo Yang, a netdev tx timeout may trigger just before an > > ethtool set_channels operation is started. be_tx_timeout(), which dumps > > some queue structures, is not written to run con

Re: [PATCH net] be2net: Synchronize be_update_queues with dev_watchdog

2019-07-18 Thread Florian Fainelli
On 7/17/19 6:42 PM, Benjamin Poirier wrote: > As pointed out by Firo Yang, a netdev tx timeout may trigger just before an > ethtool set_channels operation is started. be_tx_timeout(), which dumps > some queue structures, is not written to run concurrently with > be_update_queues(), which frees/allo

[PATCH net] be2net: Synchronize be_update_queues with dev_watchdog

2019-07-17 Thread Benjamin Poirier
As pointed out by Firo Yang, a netdev tx timeout may trigger just before an ethtool set_channels operation is started. be_tx_timeout(), which dumps some queue structures, is not written to run concurrently with be_update_queues(), which frees/allocates those queues structures. Add some synchronizat