Re: [PATCH net] __netif_receive_skb_core: pass skb by reference

2020-05-19 Thread Boris Sukholitko
On Mon, May 18, 2020 at 08:59:56AM -0700, Eric Dumazet wrote: > > Please provide a Fixes: tag for such a scary patch. Done in v2. Thanks, Boris.

Re: [PATCH net] __netif_receive_skb_core: pass skb by reference

2020-05-19 Thread Boris Sukholitko
On Mon, May 18, 2020 at 05:20:13PM +0100, Edward Cree wrote: > Firstly, please add a Fixes: tag; I expect the relevant commit will be >  88eb1944e18c ("net: core: propagate SKB lists through packet_type lookup") >  but I'm not 100% sure so do check that yourself. You are right, this is the right c

Re: [PATCH net] __netif_receive_skb_core: pass skb by reference

2020-05-18 Thread Edward Cree
On 18/05/2020 10:01, Boris Sukholitko wrote: > __netif_receive_skb_core may change the skb pointer passed into it (e.g. > in rx_handler). The original skb may be freed as a result of this > operation. > > The callers of __netif_receive_skb_core may further process original skb > by using pt_prev po

Re: [PATCH net] __netif_receive_skb_core: pass skb by reference

2020-05-18 Thread Eric Dumazet
On 5/18/20 2:01 AM, Boris Sukholitko wrote: > __netif_receive_skb_core may change the skb pointer passed into it (e.g. > in rx_handler). The original skb may be freed as a result of this > operation. > > The callers of __netif_receive_skb_core may further process original skb > by using pt_prev

[PATCH net] __netif_receive_skb_core: pass skb by reference

2020-05-18 Thread Boris Sukholitko
__netif_receive_skb_core may change the skb pointer passed into it (e.g. in rx_handler). The original skb may be freed as a result of this operation. The callers of __netif_receive_skb_core may further process original skb by using pt_prev pointer returned by __netif_receive_skb_core thus leading