Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-10 Thread Leon Romanovsky
On Fri, Jan 08, 2021 at 09:21:45AM -0700, Alex Williamson wrote: > On Fri, 8 Jan 2021 09:25:25 +0200 > Leon Romanovsky wrote: > > > On Thu, Jan 07, 2021 at 10:54:38PM -0500, Don Dutile wrote: > > > On 1/7/21 7:57 PM, Bjorn Helgaas wrote: > > > > [+cc Alex, Don] > > > > <...> > > > > > > Help me co

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-10 Thread Leon Romanovsky
On Fri, Jan 08, 2021 at 09:54:47PM -0500, Don Dutile wrote: > On 1/8/21 4:09 PM, Bjorn Helgaas wrote: > > On Thu, Jan 07, 2021 at 10:54:38PM -0500, Don Dutile wrote: > > > On 1/7/21 7:57 PM, Bjorn Helgaas wrote: > > > > On Sun, Jan 03, 2021 at 10:24:37AM +0200, Leon Romanovsky wrote: > > > > > + **

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-10 Thread Leon Romanovsky
On Thu, Jan 07, 2021 at 10:54:38PM -0500, Don Dutile wrote: > On 1/7/21 7:57 PM, Bjorn Helgaas wrote: > > [+cc Alex, Don] > > > > This patch does not actually *configure* the number of vectors, so the > > subject is not quite accurate. IIUC, this patch adds a sysfs file > > that can be used to con

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-10 Thread Leon Romanovsky
On Fri, Jan 08, 2021 at 03:09:13PM -0600, Bjorn Helgaas wrote: > On Thu, Jan 07, 2021 at 10:54:38PM -0500, Don Dutile wrote: > > On 1/7/21 7:57 PM, Bjorn Helgaas wrote: > > > On Sun, Jan 03, 2021 at 10:24:37AM +0200, Leon Romanovsky wrote: > > > > > + **/ > > > > +int pci_set_msix_vec_count(struct

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-10 Thread Leon Romanovsky
On Thu, Jan 07, 2021 at 06:57:21PM -0600, Bjorn Helgaas wrote: > [+cc Alex, Don] > > This patch does not actually *configure* the number of vectors, so the > subject is not quite accurate. IIUC, this patch adds a sysfs file > that can be used to configure the number of vectors. The subject > shou

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-08 Thread Don Dutile
On 1/8/21 4:09 PM, Bjorn Helgaas wrote: On Thu, Jan 07, 2021 at 10:54:38PM -0500, Don Dutile wrote: On 1/7/21 7:57 PM, Bjorn Helgaas wrote: On Sun, Jan 03, 2021 at 10:24:37AM +0200, Leon Romanovsky wrote: + **/ +int pci_set_msix_vec_count(struct pci_dev *dev, int numb) +{ + struct pci_de

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-08 Thread Bjorn Helgaas
On Thu, Jan 07, 2021 at 10:54:38PM -0500, Don Dutile wrote: > On 1/7/21 7:57 PM, Bjorn Helgaas wrote: > > On Sun, Jan 03, 2021 at 10:24:37AM +0200, Leon Romanovsky wrote: > > > + **/ > > > +int pci_set_msix_vec_count(struct pci_dev *dev, int numb) > > > +{ > > > + struct pci_dev *pdev = pci_physfn

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-08 Thread Alex Williamson
On Fri, 8 Jan 2021 09:25:25 +0200 Leon Romanovsky wrote: > On Thu, Jan 07, 2021 at 10:54:38PM -0500, Don Dutile wrote: > > On 1/7/21 7:57 PM, Bjorn Helgaas wrote: > > > [+cc Alex, Don] > > <...> > > > > Help me connect the dots here. Is this required because of something > > > peculiar to

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-07 Thread Leon Romanovsky
On Thu, Jan 07, 2021 at 10:54:38PM -0500, Don Dutile wrote: > On 1/7/21 7:57 PM, Bjorn Helgaas wrote: > > [+cc Alex, Don] <...> > > Help me connect the dots here. Is this required because of something > > peculiar to mlx5, or is something like this required for all SR-IOV > > devices because of

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-07 Thread Don Dutile
On 1/7/21 7:57 PM, Bjorn Helgaas wrote: [+cc Alex, Don] This patch does not actually *configure* the number of vectors, so the subject is not quite accurate. IIUC, this patch adds a sysfs file that can be used to configure the number of vectors. The subject should mention the sysfs connection.

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-07 Thread Bjorn Helgaas
[+cc Alex, Don] This patch does not actually *configure* the number of vectors, so the subject is not quite accurate. IIUC, this patch adds a sysfs file that can be used to configure the number of vectors. The subject should mention the sysfs connection. On Sun, Jan 03, 2021 at 10:24:37AM +0200

[PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-03 Thread Leon Romanovsky
From: Leon Romanovsky This function is applicable for SR-IOV VFs because such devices allocate their MSI-X table before they will run on the targeted hardware and they can't guess the right amount of vectors. Signed-off-by: Leon Romanovsky --- Documentation/ABI/testing/sysfs-bus-pci | 16 +