Re: [PATCH mlx5-next 1/3] net/mlx5: Refactor query port speed functions

2020-08-27 Thread Jason Gunthorpe
On Mon, Aug 24, 2020 at 01:58:24PM +0300, Leon Romanovsky wrote: > @@ -490,7 +490,7 @@ static int mlx5_query_port_roce(struct ib_device *device, > u8 port_num, > props->active_width = IB_WIDTH_4X; > props->active_speed = IB_SPEED_QDR; > > - translate_eth_proto_oper(eth_p

[PATCH mlx5-next 1/3] net/mlx5: Refactor query port speed functions

2020-08-24 Thread Leon Romanovsky
From: Aharon Landau The functions mlx5_query_port_link_width_oper and mlx5_query_port_ib_proto_oper are always called together, so combine them to a new function called mlx5_query_port_oper to avoid duplication. And while the mlx5i_get_port_settings is the same as mlx5_query_port_oper therefore