Re: [PATCH iptables] libxtables/xtables.c - compiler warning fixes for NO_SHARED_LIBS

2020-07-03 Thread Pablo Neira Ayuso
On Tue, Jun 23, 2020 at 04:09:02PM -0700, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > Fixes two issues with NO_SHARED_LIBS: > - #include is ifdef'ed out and thus dlclose() >triggers an undeclared function compiler warning > - dlreg_add() is unused and thus triggers an unused

Re: [PATCH iptables] libxtables/xtables.c - compiler warning fixes for NO_SHARED_LIBS

2020-06-23 Thread Maciej Żenczykowski
> void xtables_fini(void) > { > +#ifndef NO_SHARED_LIBS > dlreg_free(); > +#endif > } Note: I also considered just adding an empty 'void dlreg_free(void) {}' function in the NO_SHARED_LIBS case, but that doesn't seem to be the prevalent style...

[PATCH iptables] libxtables/xtables.c - compiler warning fixes for NO_SHARED_LIBS

2020-06-23 Thread Maciej Żenczykowski
From: Maciej Żenczykowski Fixes two issues with NO_SHARED_LIBS: - #include is ifdef'ed out and thus dlclose() triggers an undeclared function compiler warning - dlreg_add() is unused and thus triggers an unused function warning Test: builds without warnings Signed-off-by: Maciej Żenczyk