Re: [PATCH ipsec-next 1/1] xfrm: don't check offload_handle for nonzero

2018-07-22 Thread Steffen Klassert
On Tue, Jun 26, 2018 at 02:19:10PM -0700, Shannon Nelson wrote: > The offload_handle should be an opaque data cookie for the driver > to use, much like the data cookie for a timer or alarm callback. > Thus, the XFRM stack should not be checking for non-zero, because > the driver might use that to s

Re: [PATCH ipsec-next 1/1] xfrm: don't check offload_handle for nonzero

2018-06-27 Thread Steffen Klassert
On Tue, Jun 26, 2018 at 02:19:10PM -0700, Shannon Nelson wrote: > The offload_handle should be an opaque data cookie for the driver > to use, much like the data cookie for a timer or alarm callback. > Thus, the XFRM stack should not be checking for non-zero, because > the driver might use that to s

[PATCH ipsec-next 1/1] xfrm: don't check offload_handle for nonzero

2018-06-26 Thread Shannon Nelson
The offload_handle should be an opaque data cookie for the driver to use, much like the data cookie for a timer or alarm callback. Thus, the XFRM stack should not be checking for non-zero, because the driver might use that to store an array reference, which could be zero, or some other zero but mea