Re: [PATCH ipsec-next] xfrm: check for xdo_dev_state_free

2017-12-14 Thread Shannon Nelson
On 12/13/2017 10:20 PM, Steffen Klassert wrote: On Mon, Dec 11, 2017 at 12:57:22PM -0800, Shannon Nelson wrote: The current XFRM code assumes that we've implemented the xdo_dev_state_free() callback, even if it is meaningless to the driver. + if (dev->features & NETIF_F_HW_ESP

Re: [PATCH ipsec-next] xfrm: check for xdo_dev_state_free

2017-12-14 Thread kbuild test robot
Hi Shannon, Thank you for the patch! Yet something to improve: [auto build test ERROR on ipsec-next/master] url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/xfrm-check-for-xdo_dev_state_free/20171214-150202 base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-ne

Re: [PATCH ipsec-next] xfrm: check for xdo_dev_state_free

2017-12-13 Thread kbuild test robot
Hi Shannon, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ipsec-next/master] url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/xfrm-check-for-xdo_dev_state_free/20171214-150202 base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ip

Re: [PATCH ipsec-next] xfrm: check for xdo_dev_state_free

2017-12-13 Thread Steffen Klassert
On Mon, Dec 11, 2017 at 12:57:22PM -0800, Shannon Nelson wrote: > The current XFRM code assumes that we've implemented the > xdo_dev_state_free() callback, even if it is meaningless to the driver. > This patch adds a check for it before calling, as done in other APIs, > and is done for the xdo_stat

[PATCH ipsec-next] xfrm: check for xdo_dev_state_free

2017-12-11 Thread Shannon Nelson
The current XFRM code assumes that we've implemented the xdo_dev_state_free() callback, even if it is meaningless to the driver. This patch adds a check for it before calling, as done in other APIs, and is done for the xdo_state_offload_ok() callback. Also, we add a check for the required add and