Re: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2019-01-14 Thread Steffen Klassert
On Mon, Jan 14, 2019 at 08:47:37AM +, Raed Salem wrote: > > -Original Message- > > From: Steffen Klassert [mailto:steffen.klass...@secunet.com] > > > > I'm thinking about removing the no_policy flag from the IPsec protocols to > > actually do the inbound policy check for these protocol

RE: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2019-01-14 Thread Raed Salem
> Subject: Re: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware > offloading > > On Mon, Jan 07, 2019 at 09:53:31AM +, Raed Salem wrote: > > > > tested based on kernel v4.20-rc7 with the patch it works when configured > with hw offload and without gro: > &g

Re: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2019-01-14 Thread Steffen Klassert
On Mon, Jan 07, 2019 at 09:53:31AM +, Raed Salem wrote: > > tested based on kernel v4.20-rc7 with the patch it works when configured with > hw offload and without gro: > topology used: > Server A (192.168.8.2) <--> GW C <---> GW D <--> Server B (192.168.9.4): > Server A (vm) connected to gate

RE: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2019-01-07 Thread Raed Salem
ubject: Re: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware > offloading > > On Fri, Jan 04, 2019 at 11:17:33AM +, Raed Salem wrote: > > > > > > I guess this works because of transport mode, here we don't have > > > different inner and outer

RE: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2019-01-04 Thread Raed Salem
> -Original Message- > From: Steffen Klassert [mailto:steffen.klass...@secunet.com] > Sent: Friday, January 04, 2019 1:22 PM > > On Fri, Jan 04, 2019 at 11:17:33AM +, Raed Salem wrote: > > > > > > I guess this works because of transport mode, here we don't have > > > different inner

Re: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2019-01-04 Thread Steffen Klassert
On Fri, Jan 04, 2019 at 11:17:33AM +, Raed Salem wrote: > > > > I guess this works because of transport mode, here we don't have different > > inner and outer IP headers. Can you please test this with some tunnel mode > > configurations? > Sure, > Works with the following SA and policy DB: > i

RE: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2019-01-04 Thread Raed Salem
> -Original Message- > From: Steffen Klassert [mailto:steffen.klass...@secunet.com] > Sent: Friday, January 04, 2019 12:55 PM> > On Fri, Jan 04, 2019 at 10:49:55AM +, Raed Salem wrote: > > > -Original Message- > > > From: Steffen Klassert [mailto:steffen.klass...@secunet.com

Re: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2019-01-04 Thread Steffen Klassert
On Fri, Jan 04, 2019 at 10:49:55AM +, Raed Salem wrote: > > -Original Message- > > From: Steffen Klassert [mailto:steffen.klass...@secunet.com] > > > > > > > > We currently don't support IPsec hardware offload without GRO enabled. > > > > This is because the IPsec hardware offload does

RE: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2019-01-04 Thread Raed Salem
uary 04, 2019 8:34 AM > > > To: Raed Salem > > > Cc: Boris Pismenny ; Yossi Kuperman > > > ; netdev@vger.kernel.org; > > > herb...@gondor.apana.org.au; da...@davemloft.net > > > Subject: Re: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec > > >

Re: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2019-01-04 Thread Steffen Klassert
uperman > > ; netdev@vger.kernel.org; > > herb...@gondor.apana.org.au; da...@davemloft.net > > Subject: Re: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware > > offloading > > > > On Thu, Dec 27, 2018 at 01:32:14PM +, Raed Salem wrote: > > > I

RE: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2019-01-04 Thread Raed Salem
ubject: Re: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware > offloading > > On Thu, Dec 27, 2018 at 01:32:14PM +, Raed Salem wrote: > > In xfrm_input() when called with IPsec hardware offload done and > > without GRO, encap_type == 0, we end up skipping esp_inp

Re: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2019-01-03 Thread Steffen Klassert
On Thu, Dec 27, 2018 at 01:32:14PM +, Raed Salem wrote: > In xfrm_input() when called with IPsec hardware offload done and without GRO, > encap_type == 0, we end up skipping esp_input_tail as crypto_done is set only > within GRO code path, fix by move out crypto_done assignment from the GRO

[PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2018-12-27 Thread Raed Salem
In xfrm_input() when called with IPsec hardware offload done and without GRO, encap_type == 0, we end up skipping esp_input_tail as crypto_done is set only within GRO code path, fix by move out crypto_done assignment from the GRO code path and change code accordingly Fixes: d77e38e612a0 ("xfrm: