Re: [PATCH iproute2 v2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Eric Dumazet
On Fri, 2015-05-29 at 15:02 -0700, Stephen Hemminger wrote: > Why not use strdupa? I handles arbitrary size? I doubt this will please security guys. RETURN VALUE The alloca() function returns a pointer to the beginning of the allocated space. If the allocation causes stack overflow, pro

Re: [PATCH iproute2 v2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Stephen Hemminger
On Fri, 29 May 2015 21:09:54 +0300 Vadim Kochan wrote: > From: Vadim Kochan > > Used 16 char array for cong alg name instead of malloc. > > Fixes: 8250bc9ff4e5 ("ss: Unify inet sockets output") > Reported-by: Jose R. Guzman Mosqueda > Signed-off-by: Vadim Kochan > --- > v2: >Used 16 byte

[PATCH iproute2 v2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Vadim Kochan
From: Vadim Kochan Used 16 char array for cong alg name instead of malloc. Fixes: 8250bc9ff4e5 ("ss: Unify inet sockets output") Reported-by: Jose R. Guzman Mosqueda Signed-off-by: Vadim Kochan --- v2: Used 16 byte array for cong alg name instead of malloc suggested by Eric Dumazet