Re: [PATCH iproute2 net-next v3 2/5] taprio: Add support for setting flags

2019-07-15 Thread Patel, Vedang
Hi Stephen, > On Jul 15, 2019, at 4:37 PM, Stephen Hemminger > wrote: > > On Mon, 15 Jul 2019 15:51:41 -0700 > Vedang Patel wrote: > >> @@ -405,6 +420,7 @@ static int taprio_print_opt(struct qdisc_util *qu, FILE >> *f, struct rtattr *opt) >> struct rtattr *tb[TCA_TAPRIO_ATTR_MAX + 1]; >

Re: [PATCH iproute2 net-next v3 2/5] taprio: Add support for setting flags

2019-07-15 Thread Jakub Kicinski
On Mon, 15 Jul 2019 17:24:22 -0700, Stephen Hemminger wrote: > On Mon, 15 Jul 2019 17:15:15 -0700 > Jakub Kicinski wrote: > > On Mon, 15 Jul 2019 16:37:43 -0700, Stephen Hemminger wrote: > > > On Mon, 15 Jul 2019 15:51:41 -0700 > > > Vedang Patel wrote: > > > > @@ -442,6 +458,11 @@ static i

Re: [PATCH iproute2 net-next v3 2/5] taprio: Add support for setting flags

2019-07-15 Thread Stephen Hemminger
On Mon, 15 Jul 2019 17:15:15 -0700 Jakub Kicinski wrote: > On Mon, 15 Jul 2019 16:37:43 -0700, Stephen Hemminger wrote: > > On Mon, 15 Jul 2019 15:51:41 -0700 > > Vedang Patel wrote: > > > @@ -442,6 +458,11 @@ static int taprio_print_opt(struct qdisc_util *qu, > > > FILE *f, struct rtattr *op

Re: [PATCH iproute2 net-next v3 2/5] taprio: Add support for setting flags

2019-07-15 Thread Jakub Kicinski
On Mon, 15 Jul 2019 16:37:43 -0700, Stephen Hemminger wrote: > On Mon, 15 Jul 2019 15:51:41 -0700 > Vedang Patel wrote: > > @@ -442,6 +458,11 @@ static int taprio_print_opt(struct qdisc_util *qu, > > FILE *f, struct rtattr *opt) > > > > print_string(PRINT_ANY, "clockid", "clockid %s", > >

Re: [PATCH iproute2 net-next v3 2/5] taprio: Add support for setting flags

2019-07-15 Thread Stephen Hemminger
On Mon, 15 Jul 2019 15:51:41 -0700 Vedang Patel wrote: > @@ -405,6 +420,7 @@ static int taprio_print_opt(struct qdisc_util *qu, FILE > *f, struct rtattr *opt) > struct rtattr *tb[TCA_TAPRIO_ATTR_MAX + 1]; > struct tc_mqprio_qopt *qopt = 0; > __s32 clockid = CLOCKID_INVALID; > +

[PATCH iproute2 net-next v3 2/5] taprio: Add support for setting flags

2019-07-15 Thread Vedang Patel
From: Vinicius Costa Gomes This allows a new parameter, flags, to be passed to taprio. Currently, it only supports enabling the txtime-assist mode. But, we plan to add different modes for taprio (e.g. hardware offloading) and this parameter will be useful in enabling those modes. Signed-off-by: