Re: [PATCH iproute2 net-next] nstat: add sctp snmp support

2016-09-04 Thread Hangbin Liu
2016-09-02 18:09 GMT+08:00 Phil Sutter : > Did you forget to add the load call to update_db(), or am I missing > something? Opps, forgot to add it there. I will send patchv2 for this issue. Thanks Hangbin > Apart from that, looks nice and clean. > > Cheers, Phil

Re: [PATCH iproute2 net-next] nstat: add sctp snmp support

2016-09-02 Thread Stephen Hemminger
On Fri, 2 Sep 2016 12:46:49 -0700 Stephen Hemminger wrote: > On Fri, 2 Sep 2016 15:12:38 +0800 > Hangbin Liu wrote: > > > SCTP module was not load by default. But this should be OK since we will not > > load table if fdopen() failed. > > > > Signed-off-by: Hangbin Liu > > This seems like

Re: [PATCH iproute2 net-next] nstat: add sctp snmp support

2016-09-02 Thread Stephen Hemminger
On Fri, 2 Sep 2016 15:12:38 +0800 Hangbin Liu wrote: > SCTP module was not load by default. But this should be OK since we will not > load table if fdopen() failed. > > Signed-off-by: Hangbin Liu This seems like a bad idea for the normal distro user. If they run nstat command the SCTP kernel

Re: [PATCH iproute2 net-next] nstat: add sctp snmp support

2016-09-02 Thread Phil Sutter
On Fri, Sep 02, 2016 at 03:12:38PM +0800, Hangbin Liu wrote: > SCTP module was not load by default. But this should be OK since we will not > load table if fdopen() failed. > > Signed-off-by: Hangbin Liu > --- > misc/nstat.c | 17 + > 1 file changed, 17 insertions(+) > > diff --

[PATCH iproute2 net-next] nstat: add sctp snmp support

2016-09-02 Thread Hangbin Liu
SCTP module was not load by default. But this should be OK since we will not load table if fdopen() failed. Signed-off-by: Hangbin Liu --- misc/nstat.c | 17 + 1 file changed, 17 insertions(+) diff --git a/misc/nstat.c b/misc/nstat.c index 6143719..8035be4 100644 --- a/misc/nsta