Re: [PATCH iproute2-next] tc: Correct json output for actions

2018-04-04 Thread Stephen Hemminger
On Wed, 04 Apr 2018 17:09:04 -0400 Roman Mashak wrote: > Yuval Mintz writes: > > > Commit 9fd3f0b255d9 ("tc: enable json output for actions") added JSON > > support for tc-actions at the expense of breaking other use cases that > > reach tc_print_action(), as the latter don't expect the 'action

Re: [PATCH iproute2-next] tc: Correct json output for actions

2018-04-04 Thread Roman Mashak
Yuval Mintz writes: > Commit 9fd3f0b255d9 ("tc: enable json output for actions") added JSON > support for tc-actions at the expense of breaking other use cases that > reach tc_print_action(), as the latter don't expect the 'actions' array > to be a new object. > > Consider the following taken dur

Re: [PATCH iproute2-next] tc: Correct json output for actions

2018-04-04 Thread David Ahern
On 4/4/18 6:24 AM, Yuval Mintz wrote: > Commit 9fd3f0b255d9 ("tc: enable json output for actions") added JSON > support for tc-actions at the expense of breaking other use cases that > reach tc_print_action(), as the latter don't expect the 'actions' array > to be a new object. > > Consider the fo

[PATCH iproute2-next] tc: Correct json output for actions

2018-04-04 Thread Yuval Mintz
Commit 9fd3f0b255d9 ("tc: enable json output for actions") added JSON support for tc-actions at the expense of breaking other use cases that reach tc_print_action(), as the latter don't expect the 'actions' array to be a new object. Consider the following taken duringrun of tc_chain.sh selftest, a