Re: [PATCH iproute2-next] ip-address: Fix negative prints of large TX rate limits

2018-03-08 Thread Tariq Toukan
On 08/03/2018 5:38 PM, Stephen Hemminger wrote: On Thu, 8 Mar 2018 15:48:27 +0200 Tariq Toukan wrote: if (vf_tx_rate->rate) print_int(PRINT_ANY, "tx_rate", - ", tx rate %d (Mbps)", + ", tx rate

Re: [PATCH iproute2-next] ip-address: Fix negative prints of large TX rate limits

2018-03-08 Thread Stephen Hemminger
On Thu, 8 Mar 2018 15:48:27 +0200 Tariq Toukan wrote: > if (vf_tx_rate->rate) > print_int(PRINT_ANY, > "tx_rate", > - ", tx rate %d (Mbps)", > + ", tx rate %u (Mbps)", > vf_tx_rate->ra

[PATCH iproute2-next] ip-address: Fix negative prints of large TX rate limits

2018-03-08 Thread Tariq Toukan
TX rate limit fields are unsigned (__u32). Print them using %u. Tested: $ ip link set ens1 vf 1 rate 2294967296 $ ip link show |grep -iE "vf 1" | grep rate before: vf 1 MAC 00:00:00:00:00:00, tx rate -20 (Mbps), max_tx_rate -20Mbps, ... after: vf 1 MAC 00:00:00:00:00:00, tx rate