Re: [PATCH iproute2] xfrm: add option to hide keys in state output

2019-01-15 Thread Benedict Wong
Friendly ping for review. If there are no concerns, I think this would be useful especially in the logging/bugreport use cases. On Mon, Jan 7, 2019 at 3:10 PM Benedict Wong wrote: > > (Accidentally sent previously as direct reply. Re-sending as reply-all) > > > ... would not it be better to not r

Re: [PATCH iproute2] xfrm: add option to hide keys in state output

2019-01-07 Thread Benedict Wong
(Accidentally sent previously as direct reply. Re-sending as reply-all) > ... would not it be better to not request the > kernel not to dump the keys to begin with ... I think it's still valid to have it in iproute2, since it does allow for backward compatibility against older kernels. Adding it

Re: [PATCH iproute2] xfrm: add option to hide keys in state output

2019-01-07 Thread Florian Fainelli
On 1/7/19 1:31 PM, Benedict Wong wrote: > ip xfrm state show currently dumps keys unconditionally. This limits its > use in logging, as security information can be leaked. > > This patch adds a nokeys option to ip xfrm ( state show | monitor ), which > prevents the printing of keys. This allows ip

[PATCH iproute2] xfrm: add option to hide keys in state output

2019-01-07 Thread Benedict Wong
ip xfrm state show currently dumps keys unconditionally. This limits its use in logging, as security information can be leaked. This patch adds a nokeys option to ip xfrm ( state show | monitor ), which prevents the printing of keys. This allows ip xfrm state show to be used in logging without exp