Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-06-25 Thread Daniel Borkmann
On 06/25/2015 05:31 AM, Stephen Hemminger wrote: On Fri, 29 May 2015 18:48:42 +0200 Daniel Borkmann wrote: On 05/29/2015 06:17 PM, Guzman Mosqueda, Jose R wrote: Hi Daniel and Vadim Thanks for your prompt response and for the patch. Also, what about the other one? Do you think it is an issu

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-06-24 Thread Stephen Hemminger
On Fri, 29 May 2015 18:48:42 +0200 Daniel Borkmann wrote: > On 05/29/2015 06:17 PM, Guzman Mosqueda, Jose R wrote: > > Hi Daniel and Vadim > > > > Thanks for your prompt response and for the patch. > > > > Also, what about the other one? Do you think it is an issue or not? > > > > " File: tc/tc_u

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Daniel Borkmann
On 05/29/2015 06:17 PM, Guzman Mosqueda, Jose R wrote: Hi Daniel and Vadim Thanks for your prompt response and for the patch. Also, what about the other one? Do you think it is an issue or not? " File: tc/tc_util.c Function: void print_rate(char *buf, int len, __u64 rate) Line: ~264 In the ca

RE: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Guzman Mosqueda, Jose R
could cause and issue, what do you think? Thanks, -José R. -Original Message- From: Daniel Borkmann [mailto:dan...@iogearbox.net] Sent: Friday, May 29, 2015 6:10 AM To: Vadim Kochan Cc: netdev@vger.kernel.org; Guzman Mosqueda, Jose R Subject: Re: [PATCH iproute2] ss: Fix allocation of

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Eric Dumazet
On Fri, 2015-05-29 at 15:53 +0300, Vadim Kochan wrote: > Thanks! > > Should I put you in "From" tag or in "Signed-off-by" ? > Or your diff might be used from this email thread ? Don't worry, just submit the patch officially on your own ;) Thanks. -- To unsubscribe from this list: send the lin

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Vadim Kochan
On Fri, May 29, 2015 at 04:04:05AM -0700, Eric Dumazet wrote: > On Fri, 2015-05-29 at 13:30 +0300, Vadim Kochan wrote: > > From: Vadim Kochan > > > > Use strdup instead of malloc, and get rid of bad strcpy. > > > > Signed-off-by: Vadim Kochan > > --- > > misc/ss.c | 3 +-- > > 1 file changed,

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Daniel Borkmann
On 05/29/2015 01:04 PM, Eric Dumazet wrote: ... I doubt TCP_CA_NAME_MAX will ever change in the kernel : 16 bytes. Its typically "cubic" and less than 8 bytes. Using 8 bytes to point to a malloc(8) is a waste. Please remove the memory allocation, or store the pointer, since tcp_show_info() doe

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Daniel Borkmann
Hi Vadim, On 05/29/2015 12:30 PM, Vadim Kochan wrote: From: Vadim Kochan Use strdup instead of malloc, and get rid of bad strcpy. Signed-off-by: Vadim Kochan Please also Cc the reporter (done here), and add a: Fixes: 8250bc9ff4e5 ("ss: Unify inet sockets output") Reported-by: Jose R. Guzm

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Eric Dumazet
On Fri, 2015-05-29 at 13:30 +0300, Vadim Kochan wrote: > From: Vadim Kochan > > Use strdup instead of malloc, and get rid of bad strcpy. > > Signed-off-by: Vadim Kochan > --- > misc/ss.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/misc/ss.c b/misc/ss.c > index 3

[PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Vadim Kochan
From: Vadim Kochan Use strdup instead of malloc, and get rid of bad strcpy. Signed-off-by: Vadim Kochan --- misc/ss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 347e3a1..a719466 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -1908,8 +1908,7 @@