Re: [PATCH iproute2] macsec: fix off-by-one when parsing attributes

2018-10-15 Thread Sabrina Dubroca
2018-10-15, 09:36:58 -0700, Stephen Hemminger wrote: > On Fri, 12 Oct 2018 17:34:12 +0200 > Sabrina Dubroca wrote: > > > I seem to have had a massive brainfart with uses of > > parse_rtattr_nested(). The rtattr* array must have MAX+1 elements, and > > the call to parse_rtattr_nested must have MAX

Re: [PATCH iproute2] macsec: fix off-by-one when parsing attributes

2018-10-15 Thread Stephen Hemminger
On Fri, 12 Oct 2018 17:34:12 +0200 Sabrina Dubroca wrote: > I seem to have had a massive brainfart with uses of > parse_rtattr_nested(). The rtattr* array must have MAX+1 elements, and > the call to parse_rtattr_nested must have MAX as its bound. Let's fix > those. > > Fixes: b26fc590ce62 ("ip:

[PATCH iproute2] macsec: fix off-by-one when parsing attributes

2018-10-12 Thread Sabrina Dubroca
I seem to have had a massive brainfart with uses of parse_rtattr_nested(). The rtattr* array must have MAX+1 elements, and the call to parse_rtattr_nested must have MAX as its bound. Let's fix those. Fixes: b26fc590ce62 ("ip: add MACsec support") Signed-off-by: Sabrina Dubroca --- ip/ipmacsec.c