Re: [PATCH iproute2] ip maddr: fix filtering by device

2017-10-23 Thread Stephen Hemminger
On Thu, 19 Oct 2017 10:21:08 +0200 (CEST) Michal Kubecek wrote: > Commit 530903dd9003 ("ip: fix igmp parsing when iface is long") uses > variable len to keep trailing colon from interface name comparison. This > variable is local to loop body but we set it in one pass and use it in > following o

Re: [PATCH iproute2] ip maddr: fix filtering by device

2017-10-19 Thread Petr Vorel
> On Thu, Oct 19, 2017 at 10:21:08AM +0200, Michal Kubecek wrote: > > Commit 530903dd9003 ("ip: fix igmp parsing when iface is long") uses > > variable len to keep trailing colon from interface name comparison. This > > variable is local to loop body but we set it in one pass and use it in > > fol

Re: [PATCH iproute2] ip maddr: fix filtering by device

2017-10-19 Thread Phil Sutter
On Thu, Oct 19, 2017 at 10:21:08AM +0200, Michal Kubecek wrote: > Commit 530903dd9003 ("ip: fix igmp parsing when iface is long") uses > variable len to keep trailing colon from interface name comparison. This > variable is local to loop body but we set it in one pass and use it in > following one

[PATCH iproute2] ip maddr: fix filtering by device

2017-10-19 Thread Michal Kubecek
Commit 530903dd9003 ("ip: fix igmp parsing when iface is long") uses variable len to keep trailing colon from interface name comparison. This variable is local to loop body but we set it in one pass and use it in following one(s) so that we are actually using (pseudo)random length for comparison.