Re: [PATCH ethtool 2/2] netlink: Print and return an error when features weren't changed

2020-08-23 Thread Michal Kubecek
On Fri, Aug 14, 2020 at 04:17:45PM +0300, Maxim Mikityanskiy wrote: > The legacy ethtool prints an error message and returns 1 if no features > were changed as requested. Port this behavior to ethtool-netlink. > req_mask is compared to wanted_mask to detect if any feature was > changed. If these ma

[PATCH ethtool 2/2] netlink: Print and return an error when features weren't changed

2020-08-14 Thread Maxim Mikityanskiy
The legacy ethtool prints an error message and returns 1 if no features were changed as requested. Port this behavior to ethtool-netlink. req_mask is compared to wanted_mask to detect if any feature was changed. If these masks are equal, it means that the kernel hasn't changed anything, and all bit