Re: [PATCH ethtool 1/2] netlink: Fix the condition for displaying actual changes

2020-08-23 Thread Michal Kubecek
On Fri, Aug 14, 2020 at 04:17:44PM +0300, Maxim Mikityanskiy wrote: > This comment in the code: > > /* result is not exactly as requested, show differences */ > > implies that the "Actual changes" output should be displayed only if the > result is not as requested, which matches the legacy et

[PATCH ethtool 1/2] netlink: Fix the condition for displaying actual changes

2020-08-14 Thread Maxim Mikityanskiy
This comment in the code: /* result is not exactly as requested, show differences */ implies that the "Actual changes" output should be displayed only if the result is not as requested, which matches the legacy ethtool behavior. However, in fact, ethtool-netlink displays "actual changes" even