Re: [PATCH ethtool 03/21] netlink: fix msgbuff_append() helper

2020-05-29 Thread Andrew Lunn
On Fri, May 29, 2020 at 01:21:22AM +0200, Michal Kubecek wrote: > As msgbuff_append() only copies protocol payload, i.e. part of the buffer > without netlink and genetlink header, and mnl_nlmsg_get_payload_len() only > subtracts netlink header length, we need to subtract genetlink header > length m

[PATCH ethtool 03/21] netlink: fix msgbuff_append() helper

2020-05-28 Thread Michal Kubecek
As msgbuff_append() only copies protocol payload, i.e. part of the buffer without netlink and genetlink header, and mnl_nlmsg_get_payload_len() only subtracts netlink header length, we need to subtract genetlink header length manually to get correct length of appended data block. Fixes: 5050607946