Re: [PATCH ethtool-next 2/5] pause: add --json support

2020-09-24 Thread Jacob Keller
On 9/24/2020 8:36 AM, Jakub Kicinski wrote: > On Wed, 23 Sep 2020 17:10:30 -0700 Jacob Keller wrote: >>> - printf("RX negotiated: %s\nTX negotiated: %s\n", >>> - rx_status ? "on" : "off", tx_status ? "on" : "off"); >>> + >>> + if (is_json_context()) { >>> + open_json_objec

Re: [PATCH ethtool-next 2/5] pause: add --json support

2020-09-24 Thread Jakub Kicinski
On Wed, 23 Sep 2020 17:10:30 -0700 Jacob Keller wrote: > > - printf("RX negotiated: %s\nTX negotiated: %s\n", > > - rx_status ? "on" : "off", tx_status ? "on" : "off"); > > + > > + if (is_json_context()) { > > + open_json_object("negotiated"); > > + print_bool(PRINT

Re: [PATCH ethtool-next 2/5] pause: add --json support

2020-09-23 Thread Jacob Keller
On 9/15/2020 4:52 PM, Jakub Kicinski wrote: > No change in normal text output: > > # ./ethtool -a eth0 > Pause parameters for eth0: > Autonegotiate:on > RX: on > TX: on > RX negotiated: on > TX negotiated: on > > JSON: > > # ./ethtool --json -a eth0 > [ { >

[PATCH ethtool-next 2/5] pause: add --json support

2020-09-15 Thread Jakub Kicinski
No change in normal text output: # ./ethtool -a eth0 Pause parameters for eth0: Autonegotiate: on RX: on TX: on RX negotiated: on TX negotiated: on JSON: # ./ethtool --json -a eth0 [ { "ifname": "eth0", "autonegotiate": true, "rx": true,