Re: [PATCH bpf v4 00/14] sockmap/tls fixes

2019-07-22 Thread John Fastabend
Daniel Borkmann wrote: > On 7/19/19 7:37 PM, Jakub Kicinski wrote: > > On Fri, 19 Jul 2019 10:29:13 -0700, Jakub Kicinski wrote: > >> John says: > >> > >> Resolve a series of splats discovered by syzbot and an unhash > >> TLS issue noted by Eric Dumazet. > > > > Sorry for the delay, this code is q

Re: [PATCH bpf v4 00/14] sockmap/tls fixes

2019-07-22 Thread John Fastabend
Jakub Kicinski wrote: > On Fri, 19 Jul 2019 10:29:13 -0700, Jakub Kicinski wrote: > > John says: > > > > Resolve a series of splats discovered by syzbot and an unhash > > TLS issue noted by Eric Dumazet. > > Sorry for the delay, this code is quite tricky. According to my testing > TLS SW and HW s

Re: [PATCH bpf v4 00/14] sockmap/tls fixes

2019-07-22 Thread Daniel Borkmann
On 7/19/19 7:37 PM, Jakub Kicinski wrote: > On Fri, 19 Jul 2019 10:29:13 -0700, Jakub Kicinski wrote: >> John says: >> >> Resolve a series of splats discovered by syzbot and an unhash >> TLS issue noted by Eric Dumazet. > > Sorry for the delay, this code is quite tricky. According to my testing >

Re: [PATCH bpf v4 00/14] sockmap/tls fixes

2019-07-19 Thread Jakub Kicinski
On Fri, 19 Jul 2019 10:29:13 -0700, Jakub Kicinski wrote: > John says: > > Resolve a series of splats discovered by syzbot and an unhash > TLS issue noted by Eric Dumazet. Sorry for the delay, this code is quite tricky. According to my testing TLS SW and HW should now work, I hope I didn't regres

[PATCH bpf v4 00/14] sockmap/tls fixes

2019-07-19 Thread Jakub Kicinski
John says: Resolve a series of splats discovered by syzbot and an unhash TLS issue noted by Eric Dumazet. The main issues revolved around interaction between TLS and sockmap tear down. TLS and sockmap could both reset sk->prot ops creating a condition where a close or unhash op could be called fo