On 2/8/21 10:41 PM, Björn Töpel wrote:
> On 2021-02-09 06:52, Andrii Nakryiko wrote:
>> On Sat, Feb 6, 2021 at 1:29 AM Björn Töpel wrote:
>>>
>>> From: Björn Töpel
>>>
>>> The test_xdp_redirect.sh script uses a bash redirect feature,
>>> '&>/dev/null'. Use '>/dev/null 2>&1' instead.
>>
>> We have
On 2021-02-09 06:52, Andrii Nakryiko wrote:
On Sat, Feb 6, 2021 at 1:29 AM Björn Töpel wrote:
From: Björn Töpel
The test_xdp_redirect.sh script uses a bash redirect feature,
'&>/dev/null'. Use '>/dev/null 2>&1' instead.
We have plenty of explicit bash uses in selftest scripts, I'm not sure
On Sat, Feb 6, 2021 at 1:29 AM Björn Töpel wrote:
>
> From: Björn Töpel
>
> The test_xdp_redirect.sh script uses a bash redirect feature,
> '&>/dev/null'. Use '>/dev/null 2>&1' instead.
We have plenty of explicit bash uses in selftest scripts, I'm not sure
it's a good idea to make scripts more v
On 2/6/21 1:26 AM, Björn Töpel wrote:
> From: Björn Töpel
>
> The test_xdp_redirect.sh script uses a bash redirect feature,
> '&>/dev/null'. Use '>/dev/null 2>&1' instead.
>
> Also remove the 'set -e' since the script actually relies on that the
> return value can be used to determine pass/fail
From: Björn Töpel
The test_xdp_redirect.sh script uses a bash redirect feature,
'&>/dev/null'. Use '>/dev/null 2>&1' instead.
Also remove the 'set -e' since the script actually relies on that the
return value can be used to determine pass/fail of the test.
Acked-by: William Tu
Fixes: 996139e80
