Re: [PATCH bpf v2] libbpf: fix to reject unknown flags in xsk_socket__create()

2019-03-12 Thread Daniel Borkmann
On 03/12/2019 09:52 PM, Daniel Borkmann wrote: > On 03/12/2019 09:02 PM, Andrii Nakryiko wrote: >> On Tue, Mar 12, 2019 at 12:44 PM Magnus Karlsson >> wrote: >>> >>> On Tue, Mar 12, 2019 at 8:27 PM Andrii Nakryiko >>> wrote: On Tue, Mar 12, 2019 at 2:00 AM Magnus Karlsson wrote: >

Re: [PATCH bpf v2] libbpf: fix to reject unknown flags in xsk_socket__create()

2019-03-12 Thread Daniel Borkmann
On 03/12/2019 09:02 PM, Andrii Nakryiko wrote: > On Tue, Mar 12, 2019 at 12:44 PM Magnus Karlsson > wrote: >> >> On Tue, Mar 12, 2019 at 8:27 PM Andrii Nakryiko >> wrote: >>> >>> On Tue, Mar 12, 2019 at 2:00 AM Magnus Karlsson >>> wrote: In xsk_socket__create(), the libbpf_flags field

Re: [PATCH bpf v2] libbpf: fix to reject unknown flags in xsk_socket__create()

2019-03-12 Thread Andrii Nakryiko
On Tue, Mar 12, 2019 at 12:44 PM Magnus Karlsson wrote: > > On Tue, Mar 12, 2019 at 8:27 PM Andrii Nakryiko > wrote: > > > > On Tue, Mar 12, 2019 at 2:00 AM Magnus Karlsson > > wrote: > > > > > > In xsk_socket__create(), the libbpf_flags field was not checked for > > > setting currently unused/u

Re: [PATCH bpf v2] libbpf: fix to reject unknown flags in xsk_socket__create()

2019-03-12 Thread Magnus Karlsson
On Tue, Mar 12, 2019 at 8:27 PM Andrii Nakryiko wrote: > > On Tue, Mar 12, 2019 at 2:00 AM Magnus Karlsson > wrote: > > > > In xsk_socket__create(), the libbpf_flags field was not checked for > > setting currently unused/unknown flags. This patch fixes that by returning > > -EINVAL if the user ha

Re: [PATCH bpf v2] libbpf: fix to reject unknown flags in xsk_socket__create()

2019-03-12 Thread Andrii Nakryiko
On Tue, Mar 12, 2019 at 2:00 AM Magnus Karlsson wrote: > > In xsk_socket__create(), the libbpf_flags field was not checked for > setting currently unused/unknown flags. This patch fixes that by returning > -EINVAL if the user has set any flag that is not in use at this point > in time. > > Fixes:

[PATCH bpf v2] libbpf: fix to reject unknown flags in xsk_socket__create()

2019-03-12 Thread Magnus Karlsson
In xsk_socket__create(), the libbpf_flags field was not checked for setting currently unused/unknown flags. This patch fixes that by returning -EINVAL if the user has set any flag that is not in use at this point in time. Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets") Reviewe