Re: [PATCH bpf v2] libbpf: Remove getsockopt() check for XDP_OPTIONS

2019-09-19 Thread Daniel Borkmann
On Mon, Sep 16, 2019 at 02:33:42PM +0200, Toke Høiland-Jørgensen wrote: > The xsk_socket__create() function fails and returns an error if it cannot > get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTIONS > was not added until kernel 5.3, so this means that creating XSK sockets

Re: [PATCH bpf v2] libbpf: Remove getsockopt() check for XDP_OPTIONS

2019-09-16 Thread Andrii Nakryiko
On Mon, Sep 16, 2019 at 6:05 AM Toke Høiland-Jørgensen wrote: > > The xsk_socket__create() function fails and returns an error if it cannot > get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTIONS > was not added until kernel 5.3, so this means that creating XSK sockets > alway

[PATCH bpf v2] libbpf: Remove getsockopt() check for XDP_OPTIONS

2019-09-16 Thread Toke Høiland-Jørgensen
The xsk_socket__create() function fails and returns an error if it cannot get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTIONS was not added until kernel 5.3, so this means that creating XSK sockets always fails on older kernels. Since the option is just used to set the zero-