Re: [PATCH bpf V2 1/2] bpf: devmap adjust uapi for attach bpf program

2020-06-09 Thread Jesper Dangaard Brouer
On Tue, 9 Jun 2020 07:47:06 -0600 David Ahern wrote: > On 6/9/20 7:31 AM, Jesper Dangaard Brouer wrote: > > This patch remove the minus-1 checks, and have zero mean feature isn't used. > > > > For consistency this should apply to other XDP fd uses as well -- like > IFLA_XDP_EXPECTED_FD and IF

Re: [PATCH bpf V2 1/2] bpf: devmap adjust uapi for attach bpf program

2020-06-09 Thread David Ahern
On 6/9/20 7:31 AM, Jesper Dangaard Brouer wrote: > This patch remove the minus-1 checks, and have zero mean feature isn't used. > For consistency this should apply to other XDP fd uses as well -- like IFLA_XDP_EXPECTED_FD and IFLA_XDP_FD.

[PATCH bpf V2 1/2] bpf: devmap adjust uapi for attach bpf program

2020-06-09 Thread Jesper Dangaard Brouer
V2: - Defer changing BPF-syscall to start at file-descriptor 1 - Use {} to zero initialise struct. The recent commit fbee97feed9b ("bpf: Add support to attach bpf program to a devmap entry"), introduced ability to attach (and run) a separate XDP bpf_prog for each devmap entry. A bpf_prog is added