Re: [PATCH bpf-next v2 13/20] bpf: add bpf_seq_printf and bpf_seq_write helpers

2020-05-08 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 2:42 PM Yonghong Song wrote: > > > > On 5/6/20 10:37 AM, Andrii Nakryiko wrote: > > On Sun, May 3, 2020 at 11:26 PM Yonghong Song wrote: > >> > >> Two helpers bpf_seq_printf and bpf_seq_write, are added for > >> writing data to the seq_file buffer. > >> > >> bpf_seq_printf

Re: [PATCH bpf-next v2 13/20] bpf: add bpf_seq_printf and bpf_seq_write helpers

2020-05-06 Thread Yonghong Song
On 5/6/20 10:37 AM, Andrii Nakryiko wrote: On Sun, May 3, 2020 at 11:26 PM Yonghong Song wrote: Two helpers bpf_seq_printf and bpf_seq_write, are added for writing data to the seq_file buffer. bpf_seq_printf supports common format string flag/width/type fields so at least I can get identic

Re: [PATCH bpf-next v2 13/20] bpf: add bpf_seq_printf and bpf_seq_write helpers

2020-05-06 Thread Andrii Nakryiko
On Sun, May 3, 2020 at 11:26 PM Yonghong Song wrote: > > Two helpers bpf_seq_printf and bpf_seq_write, are added for > writing data to the seq_file buffer. > > bpf_seq_printf supports common format string flag/width/type > fields so at least I can get identical results for > netlink and ipv6_route

[PATCH bpf-next v2 13/20] bpf: add bpf_seq_printf and bpf_seq_write helpers

2020-05-03 Thread Yonghong Song
Two helpers bpf_seq_printf and bpf_seq_write, are added for writing data to the seq_file buffer. bpf_seq_printf supports common format string flag/width/type fields so at least I can get identical results for netlink and ipv6_route targets. For bpf_seq_printf and bpf_seq_write, return value -EOVE