Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-29 Thread Yonghong Song
On 4/29/20 8:06 PM, Alexei Starovoitov wrote: On 4/29/20 1:15 PM, Yonghong Song wrote: Even without lseek stop() will be called multiple times. If I read seq_file.c correctly it will be called before every copy_to_user(). Which means that for a lot of text (or if read() is done with small bu

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-29 Thread Alexei Starovoitov
On 4/29/20 1:15 PM, Yonghong Song wrote: Even without lseek stop() will be called multiple times. If I read seq_file.c correctly it will be called before every copy_to_user(). Which means that for a lot of text (or if read() is done with small buffer) there will be plenty of start,show,show,stop

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-29 Thread Yonghong Song
On 4/29/20 12:19 PM, Andrii Nakryiko wrote: On Wed, Apr 29, 2020 at 8:34 AM Alexei Starovoitov wrote: On 4/28/20 11:44 PM, Yonghong Song wrote: On 4/28/20 11:40 PM, Andrii Nakryiko wrote: On Tue, Apr 28, 2020 at 11:30 PM Alexei Starovoitov wrote: On 4/28/20 11:20 PM, Yonghong Song wr

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-29 Thread Andrii Nakryiko
On Tue, Apr 28, 2020 at 11:51 PM Yonghong Song wrote: > > > > On 4/28/20 11:34 PM, Martin KaFai Lau wrote: > > On Tue, Apr 28, 2020 at 11:20:30PM -0700, Yonghong Song wrote: > >> > >> > >> On 4/28/20 11:08 PM, Andrii Nakryiko wrote: > >>> On Tue, Apr 28, 2020 at 10:10 PM Yonghong Song wrote: > >>

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-29 Thread Andrii Nakryiko
On Wed, Apr 29, 2020 at 8:34 AM Alexei Starovoitov wrote: > > On 4/28/20 11:44 PM, Yonghong Song wrote: > > > > > > On 4/28/20 11:40 PM, Andrii Nakryiko wrote: > >> On Tue, Apr 28, 2020 at 11:30 PM Alexei Starovoitov wrote: > >>> > >>> On 4/28/20 11:20 PM, Yonghong Song wrote: > > > >>>

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-29 Thread Yonghong Song
On 4/29/20 8:34 AM, Alexei Starovoitov wrote: On 4/28/20 11:44 PM, Yonghong Song wrote: On 4/28/20 11:40 PM, Andrii Nakryiko wrote: On Tue, Apr 28, 2020 at 11:30 PM Alexei Starovoitov wrote: On 4/28/20 11:20 PM, Yonghong Song wrote: On 4/28/20 11:08 PM, Andrii Nakryiko wrote: On Tue

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-29 Thread Alexei Starovoitov
On 4/28/20 11:44 PM, Yonghong Song wrote: On 4/28/20 11:40 PM, Andrii Nakryiko wrote: On Tue, Apr 28, 2020 at 11:30 PM Alexei Starovoitov wrote: On 4/28/20 11:20 PM, Yonghong Song wrote: On 4/28/20 11:08 PM, Andrii Nakryiko wrote: On Tue, Apr 28, 2020 at 10:10 PM Yonghong Song wrote:

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Yonghong Song
On 4/28/20 11:34 PM, Martin KaFai Lau wrote: On Tue, Apr 28, 2020 at 11:20:30PM -0700, Yonghong Song wrote: On 4/28/20 11:08 PM, Andrii Nakryiko wrote: On Tue, Apr 28, 2020 at 10:10 PM Yonghong Song wrote: On 4/28/20 7:44 PM, Alexei Starovoitov wrote: On 4/28/20 6:15 PM, Yonghong Son

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Yonghong Song
On 4/28/20 11:40 PM, Andrii Nakryiko wrote: On Tue, Apr 28, 2020 at 11:30 PM Alexei Starovoitov wrote: On 4/28/20 11:20 PM, Yonghong Song wrote: On 4/28/20 11:08 PM, Andrii Nakryiko wrote: On Tue, Apr 28, 2020 at 10:10 PM Yonghong Song wrote: On 4/28/20 7:44 PM, Alexei Starovoitov

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Andrii Nakryiko
On Tue, Apr 28, 2020 at 11:30 PM Alexei Starovoitov wrote: > > On 4/28/20 11:20 PM, Yonghong Song wrote: > > > > > > On 4/28/20 11:08 PM, Andrii Nakryiko wrote: > >> On Tue, Apr 28, 2020 at 10:10 PM Yonghong Song wrote: > >>> > >>> > >>> > >>> On 4/28/20 7:44 PM, Alexei Starovoitov wrote: >

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Martin KaFai Lau
On Tue, Apr 28, 2020 at 11:20:30PM -0700, Yonghong Song wrote: > > > On 4/28/20 11:08 PM, Andrii Nakryiko wrote: > > On Tue, Apr 28, 2020 at 10:10 PM Yonghong Song wrote: > > > > > > > > > > > > On 4/28/20 7:44 PM, Alexei Starovoitov wrote: > > > > On 4/28/20 6:15 PM, Yonghong Song wrote: > >

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Alexei Starovoitov
On 4/28/20 11:20 PM, Yonghong Song wrote: On 4/28/20 11:08 PM, Andrii Nakryiko wrote: On Tue, Apr 28, 2020 at 10:10 PM Yonghong Song wrote: On 4/28/20 7:44 PM, Alexei Starovoitov wrote: On 4/28/20 6:15 PM, Yonghong Song wrote: On 4/28/20 5:48 PM, Alexei Starovoitov wrote: On 4/28/20

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Yonghong Song
On 4/28/20 11:08 PM, Andrii Nakryiko wrote: On Tue, Apr 28, 2020 at 10:10 PM Yonghong Song wrote: On 4/28/20 7:44 PM, Alexei Starovoitov wrote: On 4/28/20 6:15 PM, Yonghong Song wrote: On 4/28/20 5:48 PM, Alexei Starovoitov wrote: On 4/28/20 5:37 PM, Martin KaFai Lau wrote: +pro

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Andrii Nakryiko
On Tue, Apr 28, 2020 at 10:10 PM Yonghong Song wrote: > > > > On 4/28/20 7:44 PM, Alexei Starovoitov wrote: > > On 4/28/20 6:15 PM, Yonghong Song wrote: > >> > >> > >> On 4/28/20 5:48 PM, Alexei Starovoitov wrote: > >>> On 4/28/20 5:37 PM, Martin KaFai Lau wrote: > > +prog = bpf_iter_get_p

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Andrii Nakryiko
On Mon, Apr 27, 2020 at 1:18 PM Yonghong Song wrote: > > The bpf_map iterator is implemented. > The bpf program is called at seq_ops show() and stop() functions. > bpf_iter_get_prog() will retrieve bpf program and other > parameters during seq_file object traversal. In show() function, > bpf progr

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Yonghong Song
On 4/28/20 7:44 PM, Alexei Starovoitov wrote: On 4/28/20 6:15 PM, Yonghong Song wrote: On 4/28/20 5:48 PM, Alexei Starovoitov wrote: On 4/28/20 5:37 PM, Martin KaFai Lau wrote: +    prog = bpf_iter_get_prog(seq, sizeof(struct bpf_iter_seq_map_info), + &meta.session_id, &m

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Alexei Starovoitov
On 4/28/20 6:15 PM, Yonghong Song wrote: On 4/28/20 5:48 PM, Alexei Starovoitov wrote: On 4/28/20 5:37 PM, Martin KaFai Lau wrote: +    prog = bpf_iter_get_prog(seq, sizeof(struct bpf_iter_seq_map_info), + &meta.session_id, &meta.seq_num, + v == (void *)0);  F

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Yonghong Song
On 4/28/20 5:48 PM, Alexei Starovoitov wrote: On 4/28/20 5:37 PM, Martin KaFai Lau wrote: +    prog = bpf_iter_get_prog(seq, sizeof(struct bpf_iter_seq_map_info), + &meta.session_id, &meta.seq_num, + v == (void *)0);  From looking at seq_file.c, when will show

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Yonghong Song
On 4/28/20 5:37 PM, Martin KaFai Lau wrote: On Mon, Apr 27, 2020 at 01:12:37PM -0700, Yonghong Song wrote: The bpf_map iterator is implemented. The bpf program is called at seq_ops show() and stop() functions. bpf_iter_get_prog() will retrieve bpf program and other parameters during seq_file

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Alexei Starovoitov
On 4/28/20 5:37 PM, Martin KaFai Lau wrote: + prog = bpf_iter_get_prog(seq, sizeof(struct bpf_iter_seq_map_info), +&meta.session_id, &meta.seq_num, +v == (void *)0); From looking at seq_file.c, when will show() be called with

Re: [PATCH bpf-next v1 03/19] bpf: add bpf_map iterator

2020-04-28 Thread Martin KaFai Lau
On Mon, Apr 27, 2020 at 01:12:37PM -0700, Yonghong Song wrote: > The bpf_map iterator is implemented. > The bpf program is called at seq_ops show() and stop() functions. > bpf_iter_get_prog() will retrieve bpf program and other > parameters during seq_file object traversal. In show() function, > bp