Re: [PATCH bpf-next RFCv3 2/6] veth: support AF_XDP TX copy-mode.

2019-01-07 Thread Toshiaki Makita
On 2019/01/06 0:55, William Tu wrote: ... >>> + /* put into rq */ >>> + skb = veth_xdp_rcv_one(rq, xdpf, &inner_xdp_xmit); >>> + if (!skb) { >>> + /* Peer side has XDP program attached */ >>> + if (inner_xdp_xmit & VETH_XDP

Re: [PATCH bpf-next RFCv3 2/6] veth: support AF_XDP TX copy-mode.

2019-01-05 Thread William Tu
Hi Toshiaki, Thanks a lot for the feedback. On Tue, Jan 1, 2019 at 5:44 AM Toshiaki Makita wrote: > > Hi, William. Nice work. > I have some feedback and questions. > > > + while (peer_rq->xsk_umem && budget--) { > > + unsigned int inner_xdp_xmit = 0; > > + unsigned in

Re: [PATCH bpf-next RFCv3 2/6] veth: support AF_XDP TX copy-mode.

2019-01-01 Thread Toshiaki Makita
Hi, William. Nice work. I have some feedback and questions. On 18/12/27 (木) 5:27:49, William Tu wrote: The patch adds support for AF_XDP async xmit. Users can use AF_XDP on both sides of the veth and get better performance, with the cost of ksoftirqd doing the xmit. The veth_xsk_async_xmit sim

[PATCH bpf-next RFCv3 2/6] veth: support AF_XDP TX copy-mode.

2018-12-26 Thread William Tu
The patch adds support for AF_XDP async xmit. Users can use AF_XDP on both sides of the veth and get better performance, with the cost of ksoftirqd doing the xmit. The veth_xsk_async_xmit simply kicks the napi function, veth_poll, to receive the packets that are on the umem transmit ring at the _