Re: [PATCH bpf-next 3/3] bpftool: support loading flow dissector

2018-11-07 Thread Stanislav Fomichev
On 11/07, Jakub Kicinski wrote: > On Wed, 7 Nov 2018 15:34:48 -0800, Stanislav Fomichev wrote: > > On 11/07, Jakub Kicinski wrote: > > > On Wed, 7 Nov 2018 15:13:33 -0800, Stanislav Fomichev wrote: > > > > On 11/07, Jakub Kicinski wrote: > > > > > On Wed, 7 Nov 2018 14:43:56 -0800, Stanislav F

Re: [PATCH bpf-next 3/3] bpftool: support loading flow dissector

2018-11-07 Thread Jakub Kicinski
On Wed, 7 Nov 2018 15:34:48 -0800, Stanislav Fomichev wrote: > On 11/07, Jakub Kicinski wrote: > > On Wed, 7 Nov 2018 15:13:33 -0800, Stanislav Fomichev wrote: > > > On 11/07, Jakub Kicinski wrote: > > > > On Wed, 7 Nov 2018 14:43:56 -0800, Stanislav Fomichev wrote: > > > > > bpftool map u

Re: [PATCH bpf-next 3/3] bpftool: support loading flow dissector

2018-11-07 Thread Stanislav Fomichev
On 11/07, Jakub Kicinski wrote: > On Wed, 7 Nov 2018 15:13:33 -0800, Stanislav Fomichev wrote: > > On 11/07, Jakub Kicinski wrote: > > > On Wed, 7 Nov 2018 14:43:56 -0800, Stanislav Fomichev wrote: > > > > bpftool map update pinned /sys/fs/bpf/flow/jmp_table \ > > > > key 0 0 0 0 \ > > >

Re: [PATCH bpf-next 3/3] bpftool: support loading flow dissector

2018-11-07 Thread Jakub Kicinski
On Wed, 7 Nov 2018 15:13:33 -0800, Stanislav Fomichev wrote: > On 11/07, Jakub Kicinski wrote: > > On Wed, 7 Nov 2018 14:43:56 -0800, Stanislav Fomichev wrote: > > > bpftool map update pinned /sys/fs/bpf/flow/jmp_table \ > > > key 0 0 0 0 \ > > > value pinned /sys/fs/bpf/flow/IP/

Re: [PATCH bpf-next 3/3] bpftool: support loading flow dissector

2018-11-07 Thread Stanislav Fomichev
On 11/07, Jakub Kicinski wrote: > On Wed, 7 Nov 2018 14:43:56 -0800, Stanislav Fomichev wrote: > > bpftool map update pinned /sys/fs/bpf/flow/jmp_table \ > > key 0 0 0 0 \ > > value pinned /sys/fs/bpf/flow/IP/0 > > Where is that /0 coming from ? Is that in source code? I don't s

Re: [PATCH bpf-next 3/3] bpftool: support loading flow dissector

2018-11-07 Thread Jakub Kicinski
On Wed, 7 Nov 2018 14:43:56 -0800, Stanislav Fomichev wrote: > bpftool map update pinned /sys/fs/bpf/flow/jmp_table \ > key 0 0 0 0 \ > value pinned /sys/fs/bpf/flow/IP/0 Where is that /0 coming from ? Is that in source code? I don't see libbpf adding it, maybe I'm missing somet

[PATCH bpf-next 3/3] bpftool: support loading flow dissector

2018-11-07 Thread Stanislav Fomichev
This commit adds support for loading/attaching/detaching flow dissector program. The structure of the flow dissector program is assumed to be the same as in the selftests: * flow_dissector section with the main entry point * a bunch of tail call progs * a jmp_table map that is populated with the t