Re: [PATCH bpf-next 1/8] bpf: offload: don't require rtnl for dev list manipulation

2017-12-20 Thread Kirill Tkhai
Hi, Jakub, thanks for looking into this. Sadly, that __bpf_prog_offload_destroy() needs rtnl_lock() context, but rwsem is still good as it became useful for next patches from the series. Please, see one small minor nit near the last hunk. Everything else looks good for me. On 20.12.2017 07:09,

[PATCH bpf-next 1/8] bpf: offload: don't require rtnl for dev list manipulation

2017-12-19 Thread Jakub Kicinski
We only need to hold rtnl_lock() around ndo calls. The device offload initialization doesn't require it. Neither will soon- -to-come querying the offload info. Use struct rw_semaphore because map offload will require sleeping with the semaphore held for read. Suggested-by: Kirill Tkhai Signed-