Re: [PATCH bpf-next 1/6] bpf: rename stack trace map operations

2018-10-09 Thread Mauricio Vasquez
On 10/08/2018 08:40 PM, Song Liu wrote: Actually, does it make sense to implement a list_map that supports both pop_head() and pop_tail()? Maybe gate one of the pop operations with options? The main issue with this approach is the mapping to the system calls. Adding a flag would complicate t

Re: [PATCH bpf-next 1/6] bpf: rename stack trace map operations

2018-10-08 Thread Song Liu
Actually, does it make sense to implement a list_map that supports both pop_head() and pop_tail()? Maybe gate one of the pop operations with options? I am asking because mixing stack with stack trace is still confusing after this patch. Thanks, Song On Mon, Oct 8, 2018 at 12:11 PM Mauricio Vasqu

[PATCH bpf-next 1/6] bpf: rename stack trace map operations

2018-10-08 Thread Mauricio Vasquez B
In the following patches queue and stack maps (FIFO and LIFO datastructures) will be implemented. In order to avoid confusion and a possible name clash rename stack_map_ops to stack_trace_map_ops Signed-off-by: Mauricio Vasquez B --- include/linux/bpf_types.h |2 +- kernel/bpf/stackmap.c