Re: [PATCH bpf-next 1/4] libbpf: fix detection of BPF helper call instruction

2020-08-20 Thread Daniel Borkmann
On 8/20/20 8:14 AM, Andrii Nakryiko wrote: BPF_CALL | BPF_JMP32 is explicitly not allowed by verifier for BPF helper calls, so don't detect it as a valid call. Also drop the check on func_id pointer, as it's currently always non-null. Reported-by: Yonghong Song Fixes: 109cea5a594f ("libbpf: San

Re: [PATCH bpf-next 1/4] libbpf: fix detection of BPF helper call instruction

2020-08-20 Thread Yonghong Song
On 8/19/20 11:14 PM, Andrii Nakryiko wrote: BPF_CALL | BPF_JMP32 is explicitly not allowed by verifier for BPF helper calls, so don't detect it as a valid call. Also drop the check on func_id pointer, as it's currently always non-null. Reported-by: Yonghong Song Fixes: 109cea5a594f ("libbpf:

[PATCH bpf-next 1/4] libbpf: fix detection of BPF helper call instruction

2020-08-19 Thread Andrii Nakryiko
BPF_CALL | BPF_JMP32 is explicitly not allowed by verifier for BPF helper calls, so don't detect it as a valid call. Also drop the check on func_id pointer, as it's currently always non-null. Reported-by: Yonghong Song Fixes: 109cea5a594f ("libbpf: Sanitize BPF program code for bpf_probe_read_{k