Re: [PATCH bpf-next 1/3] bpf: introduce helper bpf_get_task_stack_trace()

2020-06-23 Thread Song Liu
> On Jun 23, 2020, at 11:45 AM, Andrii Nakryiko > wrote: > > On Tue, Jun 23, 2020 at 12:08 AM Song Liu wrote: >> >> This helper can be used with bpf_iter__task to dump all /proc/*/stack to >> a seq_file. >> >> Signed-off-by: Song Liu >> --- >> include/uapi/linux/bpf.h | 10 +

Re: [PATCH bpf-next 1/3] bpf: introduce helper bpf_get_task_stack_trace()

2020-06-23 Thread Andrii Nakryiko
On Tue, Jun 23, 2020 at 12:08 AM Song Liu wrote: > > This helper can be used with bpf_iter__task to dump all /proc/*/stack to > a seq_file. > > Signed-off-by: Song Liu > --- > include/uapi/linux/bpf.h | 10 +- > kernel/trace/bpf_trace.c | 21 + > scripts/b

Re: [PATCH bpf-next 1/3] bpf: introduce helper bpf_get_task_stack_trace()

2020-06-23 Thread Andrii Nakryiko
On Tue, Jun 23, 2020 at 10:00 AM Song Liu wrote: > > > > > On Jun 23, 2020, at 8:19 AM, Alexei Starovoitov > > wrote: > > > > On Tue, Jun 23, 2020 at 12:08 AM Song Liu wrote: > >> > > [...] > > >> > >> +BPF_CALL_3(bpf_get_task_stack_trace, struct task_struct *, task, > >> + void *, ent

Re: [PATCH bpf-next 1/3] bpf: introduce helper bpf_get_task_stack_trace()

2020-06-23 Thread Song Liu
> On Jun 23, 2020, at 9:59 AM, Song Liu wrote: > > > >> On Jun 23, 2020, at 8:19 AM, Alexei Starovoitov >> wrote: >> >> On Tue, Jun 23, 2020 at 12:08 AM Song Liu wrote: >>> > > [...] > >>> >>> +BPF_CALL_3(bpf_get_task_stack_trace, struct task_struct *, task, >>> + void *, en

Re: [PATCH bpf-next 1/3] bpf: introduce helper bpf_get_task_stack_trace()

2020-06-23 Thread Song Liu
> On Jun 23, 2020, at 8:22 AM, Daniel Borkmann wrote: > > On 6/23/20 9:08 AM, Song Liu wrote: >> This helper can be used with bpf_iter__task to dump all /proc/*/stack to >> a seq_file. >> Signed-off-by: Song Liu >> --- >> include/uapi/linux/bpf.h | 10 +- >> kernel/trace/bpf_tr

Re: [PATCH bpf-next 1/3] bpf: introduce helper bpf_get_task_stack_trace()

2020-06-23 Thread Song Liu
> On Jun 23, 2020, at 8:19 AM, Alexei Starovoitov > wrote: > > On Tue, Jun 23, 2020 at 12:08 AM Song Liu wrote: >> [...] >> >> +BPF_CALL_3(bpf_get_task_stack_trace, struct task_struct *, task, >> + void *, entries, u32, size) >> +{ >> + return stack_trace_save_tsk(task, (u

Re: [PATCH bpf-next 1/3] bpf: introduce helper bpf_get_task_stack_trace()

2020-06-23 Thread Daniel Borkmann
On 6/23/20 9:08 AM, Song Liu wrote: This helper can be used with bpf_iter__task to dump all /proc/*/stack to a seq_file. Signed-off-by: Song Liu --- include/uapi/linux/bpf.h | 10 +- kernel/trace/bpf_trace.c | 21 + scripts/bpf_helpers_doc.py | 2

Re: [PATCH bpf-next 1/3] bpf: introduce helper bpf_get_task_stack_trace()

2020-06-23 Thread Alexei Starovoitov
On Tue, Jun 23, 2020 at 12:08 AM Song Liu wrote: > > This helper can be used with bpf_iter__task to dump all /proc/*/stack to > a seq_file. > > Signed-off-by: Song Liu > --- > include/uapi/linux/bpf.h | 10 +- > kernel/trace/bpf_trace.c | 21 + > scripts/b

[PATCH bpf-next 1/3] bpf: introduce helper bpf_get_task_stack_trace()

2020-06-23 Thread Song Liu
This helper can be used with bpf_iter__task to dump all /proc/*/stack to a seq_file. Signed-off-by: Song Liu --- include/uapi/linux/bpf.h | 10 +- kernel/trace/bpf_trace.c | 21 + scripts/bpf_helpers_doc.py | 2 ++ tools/include/uapi/linux/bpf.h | 10