Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-22 Thread Martin KaFai Lau
On Sat, Mar 20, 2021 at 10:18:36AM -0700, Andrii Nakryiko wrote: > > From test_ksyms.c: > > [22] DATASEC '.ksyms' size=0 vlen=5 > > type_id=12 offset=0 size=1 > > type_id=13 offset=0 size=1 > > > > For extern, does it make sense for the libbpf to assign 0 to > > both var offset and size s

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-20 Thread Andrii Nakryiko
On Fri, Mar 19, 2021 at 5:13 PM Martin KaFai Lau wrote: > > On Fri, Mar 19, 2021 at 04:02:27PM -0700, Andrii Nakryiko wrote: > > On Fri, Mar 19, 2021 at 3:45 PM Martin KaFai Lau wrote: > > > > > > On Fri, Mar 19, 2021 at 03:29:57PM -0700, Andrii Nakryiko wrote: > > > > On Fri, Mar 19, 2021 at 3:1

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-19 Thread Martin KaFai Lau
On Fri, Mar 19, 2021 at 04:02:27PM -0700, Andrii Nakryiko wrote: > On Fri, Mar 19, 2021 at 3:45 PM Martin KaFai Lau wrote: > > > > On Fri, Mar 19, 2021 at 03:29:57PM -0700, Andrii Nakryiko wrote: > > > On Fri, Mar 19, 2021 at 3:19 PM Martin KaFai Lau wrote: > > > > > > > > On Fri, Mar 19, 2021 at

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-19 Thread Andrii Nakryiko
On Fri, Mar 19, 2021 at 3:45 PM Martin KaFai Lau wrote: > > On Fri, Mar 19, 2021 at 03:29:57PM -0700, Andrii Nakryiko wrote: > > On Fri, Mar 19, 2021 at 3:19 PM Martin KaFai Lau wrote: > > > > > > On Fri, Mar 19, 2021 at 02:27:13PM -0700, Andrii Nakryiko wrote: > > > > On Thu, Mar 18, 2021 at 10:

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-19 Thread Martin KaFai Lau
On Fri, Mar 19, 2021 at 03:29:57PM -0700, Andrii Nakryiko wrote: > On Fri, Mar 19, 2021 at 3:19 PM Martin KaFai Lau wrote: > > > > On Fri, Mar 19, 2021 at 02:27:13PM -0700, Andrii Nakryiko wrote: > > > On Thu, Mar 18, 2021 at 10:29 PM Martin KaFai Lau wrote: > > > > > > > > On Thu, Mar 18, 2021 a

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-19 Thread Andrii Nakryiko
On Fri, Mar 19, 2021 at 3:19 PM Martin KaFai Lau wrote: > > On Fri, Mar 19, 2021 at 02:27:13PM -0700, Andrii Nakryiko wrote: > > On Thu, Mar 18, 2021 at 10:29 PM Martin KaFai Lau wrote: > > > > > > On Thu, Mar 18, 2021 at 09:13:56PM -0700, Andrii Nakryiko wrote: > > > > On Thu, Mar 18, 2021 at 4:

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-19 Thread Martin KaFai Lau
On Fri, Mar 19, 2021 at 02:27:13PM -0700, Andrii Nakryiko wrote: > On Thu, Mar 18, 2021 at 10:29 PM Martin KaFai Lau wrote: > > > > On Thu, Mar 18, 2021 at 09:13:56PM -0700, Andrii Nakryiko wrote: > > > On Thu, Mar 18, 2021 at 4:39 PM Martin KaFai Lau wrote: > > > > > > > > On Thu, Mar 18, 2021 a

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-19 Thread Andrii Nakryiko
On Thu, Mar 18, 2021 at 10:29 PM Martin KaFai Lau wrote: > > On Thu, Mar 18, 2021 at 09:13:56PM -0700, Andrii Nakryiko wrote: > > On Thu, Mar 18, 2021 at 4:39 PM Martin KaFai Lau wrote: > > > > > > On Thu, Mar 18, 2021 at 03:53:38PM -0700, Andrii Nakryiko wrote: > > > > On Tue, Mar 16, 2021 at 12

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-18 Thread Martin KaFai Lau
On Thu, Mar 18, 2021 at 09:13:56PM -0700, Andrii Nakryiko wrote: > On Thu, Mar 18, 2021 at 4:39 PM Martin KaFai Lau wrote: > > > > On Thu, Mar 18, 2021 at 03:53:38PM -0700, Andrii Nakryiko wrote: > > > On Tue, Mar 16, 2021 at 12:01 AM Martin KaFai Lau wrote: > > > > > > > > This patch makes BTF v

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-18 Thread Andrii Nakryiko
On Thu, Mar 18, 2021 at 4:39 PM Martin KaFai Lau wrote: > > On Thu, Mar 18, 2021 at 03:53:38PM -0700, Andrii Nakryiko wrote: > > On Tue, Mar 16, 2021 at 12:01 AM Martin KaFai Lau wrote: > > > > > > This patch makes BTF verifier to accept extern func. It is used for > > > allowing bpf program to c

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-18 Thread Martin KaFai Lau
On Thu, Mar 18, 2021 at 03:53:38PM -0700, Andrii Nakryiko wrote: > On Tue, Mar 16, 2021 at 12:01 AM Martin KaFai Lau wrote: > > > > This patch makes BTF verifier to accept extern func. It is used for > > allowing bpf program to call a limited set of kernel functions > > in a later patch. > > > > W

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-18 Thread Andrii Nakryiko
On Tue, Mar 16, 2021 at 12:01 AM Martin KaFai Lau wrote: > > This patch makes BTF verifier to accept extern func. It is used for > allowing bpf program to call a limited set of kernel functions > in a later patch. > > When writing bpf prog, the extern kernel function needs > to be declared under a

[PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-15 Thread Martin KaFai Lau
This patch makes BTF verifier to accept extern func. It is used for allowing bpf program to call a limited set of kernel functions in a later patch. When writing bpf prog, the extern kernel function needs to be declared under a ELF section (".ksyms") which is the same as the current extern kernel