Re: [PATCH bpf-next] selftests/bpf: don't destroy failed link

2020-07-29 Thread Daniel Borkmann
On 7/29/20 6:50 AM, Andrii Nakryiko wrote: Check that link is NULL or proper pointer before invoking bpf_link__destroy(). Not doing this causes crash in test_progs, when cg_storage_multi selftest fails. Cc: YiFei Zhu Fixes: 3573f384014f ("selftests/bpf: Test CGROUP_STORAGE behavior on shared eg

Re: [PATCH bpf-next] selftests/bpf: don't destroy failed link

2020-07-28 Thread Andrii Nakryiko
On Tue, Jul 28, 2020 at 10:47 PM Song Liu wrote: > > On Tue, Jul 28, 2020 at 9:54 PM Andrii Nakryiko wrote: > > > > Check that link is NULL or proper pointer before invoking > > bpf_link__destroy(). > > Not doing this causes crash in test_progs, when cg_storage_multi selftest > > fails. > > > >

Re: [PATCH bpf-next] selftests/bpf: don't destroy failed link

2020-07-28 Thread Song Liu
On Tue, Jul 28, 2020 at 9:54 PM Andrii Nakryiko wrote: > > Check that link is NULL or proper pointer before invoking bpf_link__destroy(). > Not doing this causes crash in test_progs, when cg_storage_multi selftest > fails. > > Cc: YiFei Zhu > Fixes: 3573f384014f ("selftests/bpf: Test CGROUP_STORA

[PATCH bpf-next] selftests/bpf: don't destroy failed link

2020-07-28 Thread Andrii Nakryiko
Check that link is NULL or proper pointer before invoking bpf_link__destroy(). Not doing this causes crash in test_progs, when cg_storage_multi selftest fails. Cc: YiFei Zhu Fixes: 3573f384014f ("selftests/bpf: Test CGROUP_STORAGE behavior on shared egress + ingress") Signed-off-by: Andrii Nakry