Re: [PATCH bpf-next] selftests/bpf: Check trampoline execution in d_path test

2020-09-15 Thread Jiri Olsa
On Mon, Sep 14, 2020 at 07:30:33PM -0700, Alexei Starovoitov wrote: > On Fri, Sep 11, 2020 at 6:16 AM Jiri Olsa wrote: > > > > On Thu, Sep 10, 2020 at 05:46:21PM -0700, Alexei Starovoitov wrote: > > > On Thu, Sep 10, 2020 at 5:22 AM Jiri Olsa wrote: > > > > > > > > Some kernels builds might inlin

Re: [PATCH bpf-next] selftests/bpf: Check trampoline execution in d_path test

2020-09-14 Thread Alexei Starovoitov
On Fri, Sep 11, 2020 at 6:16 AM Jiri Olsa wrote: > > On Thu, Sep 10, 2020 at 05:46:21PM -0700, Alexei Starovoitov wrote: > > On Thu, Sep 10, 2020 at 5:22 AM Jiri Olsa wrote: > > > > > > Some kernels builds might inline vfs_getattr call within > > > fstat syscall code path, so fentry/vfs_getattr t

Re: [PATCH bpf-next] selftests/bpf: Check trampoline execution in d_path test

2020-09-11 Thread Jiri Olsa
On Thu, Sep 10, 2020 at 03:22:10PM -0700, Andrii Nakryiko wrote: > On Thu, Sep 10, 2020 at 5:25 AM Jiri Olsa wrote: > > > > Some kernels builds might inline vfs_getattr call within > > fstat syscall code path, so fentry/vfs_getattr trampoline > > is not called. > > > > I'm not sure how to handle t

Re: [PATCH bpf-next] selftests/bpf: Check trampoline execution in d_path test

2020-09-11 Thread Jiri Olsa
On Thu, Sep 10, 2020 at 05:46:21PM -0700, Alexei Starovoitov wrote: > On Thu, Sep 10, 2020 at 5:22 AM Jiri Olsa wrote: > > > > Some kernels builds might inline vfs_getattr call within > > fstat syscall code path, so fentry/vfs_getattr trampoline > > is not called. > > > > I'm not sure how to handl

Re: [PATCH bpf-next] selftests/bpf: Check trampoline execution in d_path test

2020-09-10 Thread Alexei Starovoitov
On Thu, Sep 10, 2020 at 5:22 AM Jiri Olsa wrote: > > Some kernels builds might inline vfs_getattr call within > fstat syscall code path, so fentry/vfs_getattr trampoline > is not called. > > I'm not sure how to handle this in some generic way other > than use some other function, but that might ge

Re: [PATCH bpf-next] selftests/bpf: Check trampoline execution in d_path test

2020-09-10 Thread Andrii Nakryiko
On Thu, Sep 10, 2020 at 5:25 AM Jiri Olsa wrote: > > Some kernels builds might inline vfs_getattr call within > fstat syscall code path, so fentry/vfs_getattr trampoline > is not called. > > I'm not sure how to handle this in some generic way other > than use some other function, but that might ge

[PATCH bpf-next] selftests/bpf: Check trampoline execution in d_path test

2020-09-10 Thread Jiri Olsa
Some kernels builds might inline vfs_getattr call within fstat syscall code path, so fentry/vfs_getattr trampoline is not called. I'm not sure how to handle this in some generic way other than use some other function, but that might get inlined at some point as well. Adding flags that indicate tr