Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Lorenzo Bianconi
> On Thu, 2020-12-10 at 20:28 +0100, Lorenzo Bianconi wrote: > > > On Thu, 2020-12-10 at 18:59 +0100, Lorenzo Bianconi wrote: > > > > On Dec 10, Maciej Fijalkowski wrote: > > > > > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi > > > > > wrote: > > > > > > > On Thu, Dec 10, 2020 at 04:5

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Saeed Mahameed
On Thu, 2020-12-10 at 20:28 +0100, Lorenzo Bianconi wrote: > > On Thu, 2020-12-10 at 18:59 +0100, Lorenzo Bianconi wrote: > > > On Dec 10, Maciej Fijalkowski wrote: > > > > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi > > > > wrote: > > > > > > On Thu, Dec 10, 2020 at 04:50:42PM +0100

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Lorenzo Bianconi
> On Thu, 2020-12-10 at 18:59 +0100, Lorenzo Bianconi wrote: > > On Dec 10, Maciej Fijalkowski wrote: > > > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi wrote: > > > > > On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi > > > > > wrote: > > > > > > Introduce xdp_init_buff uti

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Maciej Fijalkowski
On Thu, Dec 10, 2020 at 06:59:45PM +0100, Lorenzo Bianconi wrote: > On Dec 10, Maciej Fijalkowski wrote: > > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi wrote: > > > > On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi wrote: > > > > > Introduce xdp_init_buff utility routine

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Saeed Mahameed
On Thu, 2020-12-10 at 18:59 +0100, Lorenzo Bianconi wrote: > On Dec 10, Maciej Fijalkowski wrote: > > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi wrote: > > > > On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi > > > > wrote: > > > > > Introduce xdp_init_buff utility routine

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Maciej Fijalkowski
On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi wrote: > > On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi wrote: > > > Introduce xdp_init_buff utility routine to initialize xdp_buff data > > > structure. Rely on xdp_init_buff in all XDP capable drivers. > > > > Hm, Jesper wa

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Alexander Duyck
On Thu, Dec 10, 2020 at 9:05 AM Maciej Fijalkowski wrote: > > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi wrote: > > > On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi wrote: > > > > Introduce xdp_init_buff utility routine to initialize xdp_buff data > > > > structure. Rel

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Lorenzo Bianconi
On Dec 10, Maciej Fijalkowski wrote: > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi wrote: > > > On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi wrote: > > > > Introduce xdp_init_buff utility routine to initialize xdp_buff data > > > > structure. Rely on xdp_init_buff in al

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Lorenzo Bianconi
> On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi wrote: > > Introduce xdp_init_buff utility routine to initialize xdp_buff data > > structure. Rely on xdp_init_buff in all XDP capable drivers. > > Hm, Jesper was suggesting two helpers, one that you implemented for things > that are set

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Maciej Fijalkowski
On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi wrote: > Introduce xdp_init_buff utility routine to initialize xdp_buff data > structure. Rely on xdp_init_buff in all XDP capable drivers. Hm, Jesper was suggesting two helpers, one that you implemented for things that are set once per NA

[PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Lorenzo Bianconi
Introduce xdp_init_buff utility routine to initialize xdp_buff data structure. Rely on xdp_init_buff in all XDP capable drivers. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/amazon/ena/ena_netdev.c| 3 +-- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 3 +-- drivers/n