Re: [PATCH bpf-next] libbpf: fix perf_buffer__free() API for sparse allocs

2020-05-28 Thread Daniel Borkmann
On Thu, May 28, 2020 at 09:24:58AM +0200, Eelco Chaudron wrote: > On 27 May 2020, at 19:58, Andrii Nakryiko wrote: > > On Wed, May 27, 2020 at 1:42 AM Eelco Chaudron > > wrote: > > > > > > In case the cpu_bufs are sparsely allocated they are not > > > all free'ed. These changes will fix this. > >

Re: [PATCH bpf-next] libbpf: fix perf_buffer__free() API for sparse allocs

2020-05-28 Thread Eelco Chaudron
On 27 May 2020, at 19:58, Andrii Nakryiko wrote: On Wed, May 27, 2020 at 1:42 AM Eelco Chaudron wrote: In case the cpu_bufs are sparsely allocated they are not all free'ed. These changes will fix this. Signed-off-by: Eelco Chaudron --- Thanks a lot! You forgot: Fixes: fb84b8224655 ("

Re: [PATCH bpf-next] libbpf: fix perf_buffer__free() API for sparse allocs

2020-05-27 Thread Andrii Nakryiko
On Wed, May 27, 2020 at 1:42 AM Eelco Chaudron wrote: > > In case the cpu_bufs are sparsely allocated they are not > all free'ed. These changes will fix this. > > Signed-off-by: Eelco Chaudron > --- Thanks a lot! You forgot: Fixes: fb84b8224655 ("libbpf: add perf buffer API") Acked-by: Andrii

[PATCH bpf-next] libbpf: fix perf_buffer__free() API for sparse allocs

2020-05-27 Thread Eelco Chaudron
In case the cpu_bufs are sparsely allocated they are not all free'ed. These changes will fix this. Signed-off-by: Eelco Chaudron --- tools/lib/bpf/libbpf.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 5d60de6fd81