Re: [PATCH bpf-next] libbpf: add debug message for each created program

On Wed, Jun 24, 2020 at 09:34:52AM -0700, Andrii Nakryiko wrote: > > Just yesterday (or two days ago, maybe), having those CO-RE relocation > logs, which I fought to keep when I added CO-RE relocs initially, > immediately shown that a person doesn't have bpf_iter compiled in its > running kernel,

Re: [PATCH bpf-next] libbpf: add debug message for each created program

On Wed, Jun 24, 2020 at 7:52 AM Alexei Starovoitov wrote: > > On Tue, Jun 23, 2020 at 11:59:40PM -0700, Andrii Nakryiko wrote: > > On Tue, Jun 23, 2020 at 11:47 PM Alexei Starovoitov > > wrote: > > > > > > On Tue, Jun 23, 2020 at 5:34 PM Andrii Nakryiko wrote: > > > > > > > > Similar message for

Re: [PATCH bpf-next] libbpf: add debug message for each created program

Alexei Starovoitov writes: > On Tue, Jun 23, 2020 at 11:59:40PM -0700, Andrii Nakryiko wrote: >> On Tue, Jun 23, 2020 at 11:47 PM Alexei Starovoitov >> wrote: >> > >> > On Tue, Jun 23, 2020 at 5:34 PM Andrii Nakryiko wrote: >> > > >> > > Similar message for map creation is extremely useful, so

Re: [PATCH bpf-next] libbpf: add debug message for each created program

On Tue, Jun 23, 2020 at 11:59:40PM -0700, Andrii Nakryiko wrote: > On Tue, Jun 23, 2020 at 11:47 PM Alexei Starovoitov > wrote: > > > > On Tue, Jun 23, 2020 at 5:34 PM Andrii Nakryiko wrote: > > > > > > Similar message for map creation is extremely useful, so add similar for > > > BPF > > > prog

Re: [PATCH bpf-next] libbpf: add debug message for each created program

On Tue, Jun 23, 2020 at 11:47 PM Alexei Starovoitov wrote: > > On Tue, Jun 23, 2020 at 5:34 PM Andrii Nakryiko wrote: > > > > Similar message for map creation is extremely useful, so add similar for BPF > > programs. > > 'extremely useful' is quite subjective. > If we land this patch then everyon

Re: [PATCH bpf-next] libbpf: add debug message for each created program

On Tue, Jun 23, 2020 at 5:34 PM Andrii Nakryiko wrote: > > Similar message for map creation is extremely useful, so add similar for BPF > programs. 'extremely useful' is quite subjective. If we land this patch then everyone will be allowed to add pr_debug() everywhere in libbpf with the same reas

[PATCH bpf-next] libbpf: add debug message for each created program

Similar message for map creation is extremely useful, so add similar for BPF programs. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 18461deb1b19..f24a90c86c58