Re: [PATCH bpf-next] bpf: Fix dev pointer dereference from sk_skb

2018-10-13 Thread Alexei Starovoitov
On Fri, Oct 12, 2018 at 02:50:53PM -0700, Joe Stringer wrote: > Dan Carpenter reports: > > The patch 6acc9b432e67: "bpf: Add helper to retrieve socket in BPF" > from Oct 2, 2018, leads to the following Smatch complaint: > > net/core/filter.c:4893 bpf_sk_lookup() > error: we previously ass

[PATCH bpf-next] bpf: Fix dev pointer dereference from sk_skb

2018-10-12 Thread Joe Stringer
Dan Carpenter reports: The patch 6acc9b432e67: "bpf: Add helper to retrieve socket in BPF" from Oct 2, 2018, leads to the following Smatch complaint: net/core/filter.c:4893 bpf_sk_lookup() error: we previously assumed 'skb->dev' could be null (see line 4885) Fix this issue by checking sk