Re: [PATCH bpf] xdp: Handle device unregister for devmap_hash map type

2019-10-18 Thread Andrii Nakryiko
On Fri, Oct 18, 2019 at 3:31 AM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Wed, Oct 16, 2019 at 9:07 AM Toke Høiland-Jørgensen > > wrote: > >> > >> It seems I forgot to add handling of devmap_hash type maps to the device > >> unregister hook for devmaps. This omission ca

Re: [PATCH bpf] xdp: Handle device unregister for devmap_hash map type

2019-10-18 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Wed, Oct 16, 2019 at 9:07 AM Toke Høiland-Jørgensen > wrote: >> >> It seems I forgot to add handling of devmap_hash type maps to the device >> unregister hook for devmaps. This omission causes devices to not be >> properly released, which causes hangs. >> >> Fix thi

Re: [PATCH bpf] xdp: Handle device unregister for devmap_hash map type

2019-10-17 Thread Andrii Nakryiko
On Wed, Oct 16, 2019 at 9:07 AM Toke Høiland-Jørgensen wrote: > > It seems I forgot to add handling of devmap_hash type maps to the device > unregister hook for devmaps. This omission causes devices to not be > properly released, which causes hangs. > > Fix this by adding the missing handler. > >

Re: [PATCH bpf] xdp: Handle device unregister for devmap_hash map type

2019-10-17 Thread Toke Høiland-Jørgensen
Alexei Starovoitov writes: > On 10/17/19 3:28 AM, Toke Høiland-Jørgensen wrote: >> Tetsuo Handa writes: >> >>> On 2019/10/16 22:28, Toke Høiland-Jørgensen wrote: It seems I forgot to add handling of devmap_hash type maps to the device unregister hook for devmaps. This omission causes

Re: [PATCH bpf] xdp: Handle device unregister for devmap_hash map type

2019-10-17 Thread Alexei Starovoitov
On 10/17/19 3:28 AM, Toke Høiland-Jørgensen wrote: > Tetsuo Handa writes: > >> On 2019/10/16 22:28, Toke Høiland-Jørgensen wrote: >>> It seems I forgot to add handling of devmap_hash type maps to the device >>> unregister hook for devmaps. This omission causes devices to not be >>> properly relea

Re: [PATCH bpf] xdp: Handle device unregister for devmap_hash map type

2019-10-17 Thread Toke Høiland-Jørgensen
Tetsuo Handa writes: > On 2019/10/16 22:28, Toke Høiland-Jørgensen wrote: >> It seems I forgot to add handling of devmap_hash type maps to the device >> unregister hook for devmaps. This omission causes devices to not be >> properly released, which causes hangs. >> >> Fix this by adding the miss

Re: [PATCH bpf] xdp: Handle device unregister for devmap_hash map type

2019-10-17 Thread Toke Høiland-Jørgensen
Martin Lau writes: > On Wed, Oct 16, 2019 at 03:28:02PM +0200, Toke Høiland-Jørgensen wrote: >> It seems I forgot to add handling of devmap_hash type maps to the device >> unregister hook for devmaps. This omission causes devices to not be >> properly released, which causes hangs. >> >> Fix this

Re: [PATCH bpf] xdp: Handle device unregister for devmap_hash map type

2019-10-16 Thread Tetsuo Handa
On 2019/10/16 22:28, Toke Høiland-Jørgensen wrote: > It seems I forgot to add handling of devmap_hash type maps to the device > unregister hook for devmaps. This omission causes devices to not be > properly released, which causes hangs. > > Fix this by adding the missing handler. > > Fixes: 6f9d4

Re: [PATCH bpf] xdp: Handle device unregister for devmap_hash map type

2019-10-16 Thread Martin Lau
On Wed, Oct 16, 2019 at 03:28:02PM +0200, Toke Høiland-Jørgensen wrote: > It seems I forgot to add handling of devmap_hash type maps to the device > unregister hook for devmaps. This omission causes devices to not be > properly released, which causes hangs. > > Fix this by adding the missing handl

[PATCH bpf] xdp: Handle device unregister for devmap_hash map type

2019-10-16 Thread Toke Høiland-Jørgensen
It seems I forgot to add handling of devmap_hash type maps to the device unregister hook for devmaps. This omission causes devices to not be properly released, which causes hangs. Fix this by adding the missing handler. Fixes: 6f9d451ab1a3 ("xdp: Add devmap_hash map type for looking up devices by