Re: [PATCH bpf] tools: bpftool: return from do_event_pipe() on bad arguments

2018-08-23 Thread Daniel Borkmann
On 08/23/2018 07:48 PM, Quentin Monnet wrote: > 2018-08-23 20:35 UTC+0300 ~ Sergei Shtylyov > >> Hello! >> >> On 08/23/2018 07:46 PM, Quentin Monnet wrote: >> >>> When command line parsing fails in the while loop in do_event_pipe() >>> because the number of arguments is incorrect or because the ke

Re: [PATCH bpf] tools: bpftool: return from do_event_pipe() on bad arguments

2018-08-23 Thread Quentin Monnet
2018-08-23 20:35 UTC+0300 ~ Sergei Shtylyov > Hello! > > On 08/23/2018 07:46 PM, Quentin Monnet wrote: > >> When command line parsing fails in the while loop in do_event_pipe() >> because the number of arguments is incorrect or because the keyword is >> unknown, an error message is displayed, bu

Re: [PATCH bpf] tools: bpftool: return from do_event_pipe() on bad arguments

2018-08-23 Thread Sergei Shtylyov
Hello! On 08/23/2018 07:46 PM, Quentin Monnet wrote: > When command line parsing fails in the while loop in do_event_pipe() > because the number of arguments is incorrect or because the keyword is > unknown, an error message is displayed, but bpfool bp-who? ;-) > remains stucked in Stuck

Re: [PATCH bpf] tools: bpftool: return from do_event_pipe() on bad arguments

2018-08-23 Thread Daniel Borkmann
On 08/23/2018 06:46 PM, Quentin Monnet wrote: > When command line parsing fails in the while loop in do_event_pipe() > because the number of arguments is incorrect or because the keyword is > unknown, an error message is displayed, but bpfool remains stucked in > the loop. Make sure we exit the loo

[PATCH bpf] tools: bpftool: return from do_event_pipe() on bad arguments

2018-08-23 Thread Quentin Monnet
When command line parsing fails in the while loop in do_event_pipe() because the number of arguments is incorrect or because the keyword is unknown, an error message is displayed, but bpfool remains stucked in the loop. Make sure we exit the loop upon failure. Fixes: f412eed9dfde ("tools: bpftool: