Re: [PATCH bpf] tools/bpftool: fix skeleton codegen

2020-06-12 Thread Alexei Starovoitov
On Fri, Jun 12, 2020 at 3:05 PM Tobias Klauser wrote: > > On 2020-06-12 at 22:16:03 +0200, Andrii Nakryiko wrote: > > Remove unnecessary check at the end of codegen() routine which makes > > codegen() > > to always fail and exit bpftool with error code. Positive value of variable > > n is not an

Re: [PATCH bpf] tools/bpftool: fix skeleton codegen

2020-06-12 Thread Tobias Klauser
On 2020-06-12 at 22:16:03 +0200, Andrii Nakryiko wrote: > Remove unnecessary check at the end of codegen() routine which makes codegen() > to always fail and exit bpftool with error code. Positive value of variable > n is not an indicator of a failure. > > Cc: Tobias Klauser > Fixes: 2c4779eff83

[PATCH bpf] tools/bpftool: fix skeleton codegen

2020-06-12 Thread Andrii Nakryiko
Remove unnecessary check at the end of codegen() routine which makes codegen() to always fail and exit bpftool with error code. Positive value of variable n is not an indicator of a failure. Cc: Tobias Klauser Fixes: 2c4779eff837 ("tools, bpftool: Exit on error in function codegen") Signed-off-by