Re: [PATCH bpf] tools/bpf: fix bpftool build with OUTPUT set

2019-07-23 Thread Ilya Leoshkevich
> Am 19.07.2019 um 20:17 schrieb Jakub Kicinski : > > On Fri, 19 Jul 2019 15:12:24 +0200, Ilya Leoshkevich wrote: >>> Am 18.07.2019 um 20:51 schrieb Jakub Kicinski >>> : >>> >>> We should probably make a script with all the ways of calling make >>> should work. Otherwise we can lose track too ea

Re: [PATCH bpf] tools/bpf: fix bpftool build with OUTPUT set

2019-07-23 Thread Lorenz Bauer
Hi Ilya, Thanks for your patch! I tried it but had problems with cross-compilation. Not sure if this is related to the patch or not though, I haven't had the time to follow up. Best Lorenz On Thu, 18 Jul 2019 at 15:20, Ilya Leoshkevich wrote: > > Hi Lorenz, > > I've been using the following pat

Re: [PATCH bpf] tools/bpf: fix bpftool build with OUTPUT set

2019-07-19 Thread Jakub Kicinski
On Fri, 19 Jul 2019 15:12:24 +0200, Ilya Leoshkevich wrote: > > Am 18.07.2019 um 20:51 schrieb Jakub Kicinski > > : > > > > We should probably make a script with all the ways of calling make > > should work. Otherwise we can lose track too easily. > > Thanks for the script! > > I’m trying to

Re: [PATCH bpf] tools/bpf: fix bpftool build with OUTPUT set

2019-07-19 Thread Ilya Leoshkevich
> Am 18.07.2019 um 20:51 schrieb Jakub Kicinski : > > We should probably make a script with all the ways of calling make > should work. Otherwise we can lose track too easily. Thanks for the script! I’m trying to make it all pass now, and hitting a weird issue in the Kbuild case. The build print

Re: [PATCH bpf] tools/bpf: fix bpftool build with OUTPUT set

2019-07-18 Thread Jakub Kicinski
On Thu, 18 Jul 2019 16:20:41 +0200, Ilya Leoshkevich wrote: > Hi Lorenz, > > I've been using the following patch for quite some time now. > Please let me know if it works for you. > > Best regards, > Ilya > > --- > > When OUTPUT is set, bpftool and libbpf put their objects into the same > direc

[PATCH bpf] tools/bpf: fix bpftool build with OUTPUT set

2019-07-18 Thread Ilya Leoshkevich
Hi Lorenz, I've been using the following patch for quite some time now. Please let me know if it works for you. Best regards, Ilya --- When OUTPUT is set, bpftool and libbpf put their objects into the same directory, and since some of them have the same names, the collision happens. Fix by inv