Re: [PATCH bpf] libbpf: handle GCC noreturn-turned-volatile quirk

2020-06-10 Thread Daniel Borkmann
On 6/10/20 7:23 AM, Andrii Nakryiko wrote: Handle a GCC quirk of emitting extra volatile modifier in DWARF (and subsequently preserved in BTF by pahole) for function pointers marked as __attribute__((noreturn)). This was the way to mark such functions before GCC 2.5 added noreturn attribute. Drop

Re: [PATCH bpf] libbpf: handle GCC noreturn-turned-volatile quirk

2020-06-10 Thread Jean-Philippe Brucker
On Tue, Jun 09, 2020 at 10:23:35PM -0700, Andrii Nakryiko wrote: > Handle a GCC quirk of emitting extra volatile modifier in DWARF (and > subsequently preserved in BTF by pahole) for function pointers marked as > __attribute__((noreturn)). This was the way to mark such functions before GCC > 2.5 ad

[PATCH bpf] libbpf: handle GCC noreturn-turned-volatile quirk

2020-06-09 Thread Andrii Nakryiko
Handle a GCC quirk of emitting extra volatile modifier in DWARF (and subsequently preserved in BTF by pahole) for function pointers marked as __attribute__((noreturn)). This was the way to mark such functions before GCC 2.5 added noreturn attribute. Drop such func_proto modifiers, similarly to how